Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Commit 7aacfa4

Browse files
committed
RepositoryHomeSelectionView tests
1 parent d0b04d7 commit 7aacfa4

File tree

2 files changed

+12
-8
lines changed

2 files changed

+12
-8
lines changed

lib/views/repository-home-selection-view.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,11 +123,13 @@ export class BareRepositoryHomeSelectionView extends React.Component {
123123
disabled: false,
124124
}];
125125

126+
/* istanbul ignore if */
126127
if (!this.props.user.organizations.edges) {
127128
return owners;
128129
}
129130

130131
for (const {node} of this.props.user.organizations.edges) {
132+
/* istanbul ignore if */
131133
if (!node) {
132134
continue;
133135
}
@@ -164,6 +166,7 @@ export class BareRepositoryHomeSelectionView extends React.Component {
164166
}
165167

166168
loadNextPage = () => {
169+
/* istanbul ignore if */
167170
if (this.props.relay.isLoading()) {
168171
setTimeout(this.loadNextPage, PAGE_DELAY);
169172
return;

test/views/repository-home-selection-view.test.js

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import AutoFocus from '../../lib/autofocus';
77
import TabGroup from '../../lib/tab-group';
88
import userQuery from '../../lib/views/__generated__/repositoryHomeSelectionView_user.graphql';
99
import {userBuilder} from '../builder/graphql/user';
10+
import {TabbableSelect, TabbableTextEditor} from '../../lib/views/tabbable';
1011

1112
describe('RepositoryHomeSelectionView', function() {
1213
let atomEnv, clock;
@@ -46,14 +47,14 @@ describe('RepositoryHomeSelectionView', function() {
4647
it('disables the select list while loading', function() {
4748
const wrapper = shallow(buildApp({isLoading: true}));
4849

49-
assert.isTrue(wrapper.find('Select').prop('disabled'));
50+
assert.isTrue(wrapper.find(TabbableSelect).prop('disabled'));
5051
});
5152

5253
it('passes a provided buffer to the name entry box', function() {
5354
const nameBuffer = new TextBuffer();
5455
const wrapper = shallow(buildApp({nameBuffer}));
5556

56-
assert.strictEqual(wrapper.find('AtomTextEditor').prop('buffer'), nameBuffer);
57+
assert.strictEqual(wrapper.find(TabbableTextEditor).prop('buffer'), nameBuffer);
5758
});
5859

5960
it('translates loaded organizations and the current user as options for the select list', function() {
@@ -79,7 +80,7 @@ describe('RepositoryHomeSelectionView', function() {
7980

8081
const wrapper = shallow(buildApp({user}));
8182

82-
assert.deepEqual(wrapper.find('Select').prop('options'), [
83+
assert.deepEqual(wrapper.find(TabbableSelect).prop('options'), [
8384
{id: 'user0', login: 'me', avatarURL: 'https://avatars2.githubusercontent.com/u/17565?s=24&v=4', disabled: false},
8485
{id: 'org0', login: 'enabled', avatarURL: 'https://avatars2.githubusercontent.com/u/1089146?s=24&v=4', disabled: false},
8586
{id: 'org1', login: 'disabled', avatarURL: 'https://avatars1.githubusercontent.com/u/1507452?s=24&v=4', disabled: true},
@@ -102,7 +103,7 @@ describe('RepositoryHomeSelectionView', function() {
102103
.build();
103104
const wrapper = shallow(buildApp({user}));
104105

105-
const optionWrapper = wrapper.find('Select').renderProp('optionRenderer')({
106+
const optionWrapper = wrapper.find(TabbableSelect).renderProp('optionRenderer')({
106107
id: user.id,
107108
login: user.login,
108109
avatarURL: user.avatarUrl,
@@ -114,7 +115,7 @@ describe('RepositoryHomeSelectionView', function() {
114115
assert.isFalse(optionWrapper.exists('.github-RepositoryHome-ownerUnwritable'));
115116

116117
const org = user.organizations.edges[0].node;
117-
const valueWrapper = wrapper.find('Select').renderProp('valueRenderer')({
118+
const valueWrapper = wrapper.find(TabbableSelect).renderProp('valueRenderer')({
118119
id: org.id,
119120
login: org.login,
120121
avatarURL: org.avatarUrl,
@@ -185,7 +186,7 @@ describe('RepositoryHomeSelectionView', function() {
185186

186187
const wrapper = shallow(buildApp({user, selectedOwnerID: 'user0'}));
187188

188-
assert.deepEqual(wrapper.find('Select').prop('value'), {
189+
assert.deepEqual(wrapper.find(TabbableSelect).prop('value'), {
189190
id: 'user0',
190191
login: 'me',
191192
avatarURL: 'https://avatars2.githubusercontent.com/u/17565?s=24&v=4',
@@ -194,7 +195,7 @@ describe('RepositoryHomeSelectionView', function() {
194195

195196
wrapper.setProps({selectedOwnerID: 'org1'});
196197

197-
assert.deepEqual(wrapper.find('Select').prop('value'), {
198+
assert.deepEqual(wrapper.find(TabbableSelect).prop('value'), {
198199
id: 'org1',
199200
login: 'one',
200201
avatarURL: 'https://avatars3.githubusercontent.com/u/13409222?s=24&v=4',
@@ -218,7 +219,7 @@ describe('RepositoryHomeSelectionView', function() {
218219

219220
const wrapper = shallow(buildApp({user, didChangeOwnerID}));
220221

221-
wrapper.find('Select').prop('onChange')(org);
222+
wrapper.find(TabbableSelect).prop('onChange')(org);
222223
assert.isTrue(didChangeOwnerID.calledWith('org0'));
223224
});
224225
});

0 commit comments

Comments
 (0)