Merge pull request #2415 from atom/blank-panels

Populate StubItem panes that are deserialized after package initialization

Author: smashwilson

lib/atom/pane-item.js

@@ -71,6 +71,37 @@ export default class PaneItem extends React.Component {
   }
 
   componentDidMount() {
+    // Listen for and adopt StubItems that are added after this component has
+    // already been mounted.
+    this.subs.add(this.props.workspace.onDidAddPaneItem(({item}) => {
+      if (!item._getStub) {
+        return;
+      }
+      const stub = item._getStub();
+
+      if (stub.getRealItem() !== null) {
+        return;
+      }
+
+      const match = this.state.uriPattern.matches(item.getURI());
+      if (!match.ok()) {
+        return;
+      }
+
+      const openItem = new OpenItem(match, stub.getElement(), stub);
+      openItem.hydrateStub({
+        copy: () => this.copyOpenItem(openItem),
+      });
+      if (this.props.className) {
+        openItem.addClassName(this.props.className);
+      }
+      this.registerCloseListener(item, openItem);
+
+      this.setState(prevState => ({
+        currentlyOpen: [...prevState.currentlyOpen, openItem],
+      }));
+    }));
+
     for (const openItem of this.state.currentlyOpen) {
       this.registerCloseListener(openItem.stubItem, openItem);
 

test/atom/pane-item.test.js

@@ -309,5 +309,19 @@ describe('PaneItem', function() {
 
       assert.isTrue(stub.getElement().classList.contains('added'));
     });
+
+    it('adopts StubItems that are deserialized after the package has been initialized', function() {
+      const wrapper = mount(
+        <PaneItem workspace={workspace} uriPattern="atom-github://pattern/root/{id}">
+          {({params, itemHolder}) => <Component ref={itemHolder.setter} text={params.id} />}
+        </PaneItem>,
+      );
+
+      const stub = StubItem.create('some-component', {title: 'Component'}, 'atom-github://pattern/root/45');
+      workspace.getActivePane().addItem(stub);
+      wrapper.update();
+
+      assert.isTrue(wrapper.exists('Component[text="45"]'));
+    });
   });
 });