Initialize and publish empty repositories

Author: smashwilson

lib/views/create-dialog.js

@@ -40,15 +40,22 @@ export async function publishRepository(
   {ownerID, name, visibility, protocol, sourceRemoteName},
   {repository, relayEnvironment},
 ) {
-  let defaultBranchName;
-  const branchSet = await repository.getBranches();
-  const branchNames = new Set(branchSet.getNames());
-  if (branchNames.has('master')) {
+  let defaultBranchName, wasEmpty;
+  if (repository.isEmpty()) {
+    wasEmpty = true;
+    await repository.init();
     defaultBranchName = 'master';
   } else {
-    const head = branchSet.getHeadBranch();
-    if (head.isPresent()) {
-      defaultBranchName = head.getName();
+    wasEmpty = false;
+    const branchSet = await repository.getBranches();
+    const branchNames = new Set(branchSet.getNames());
+    if (branchNames.has('master')) {
+      defaultBranchName = 'master';
+    } else {
+      const head = branchSet.getHeadBranch();
+      if (head.isPresent()) {
+        defaultBranchName = head.getName();
+      }
     }
   }
   if (!defaultBranchName) {
@@ -58,5 +65,7 @@ export async function publishRepository(
   const result = await createRepositoryMutation(relayEnvironment, {name, ownerID, visibility});
   const sourceURL = result.createRepository.repository[protocol === 'ssh' ? 'sshUrl' : 'url'];
   const remote = await repository.addRemote(sourceRemoteName, sourceURL);
-  await repository.push(defaultBranchName, {remote, setUpstream: true});
+  if (!wasEmpty) {
+    await repository.push(defaultBranchName, {remote, setUpstream: true});
+  }
 }

test/views/create-dialog.test.js

@@ -292,6 +292,40 @@ describe('CreateDialog', function() {
       assert.isTrue(repository.push.calledWith('other-branch', {remote: CREATED_REMOTE, setUpstream: true}));
     });
 
+    it('initializes an empty repository', async function() {
+      expectRelayQuery({
+        name: createRepositoryQuery.operation.name,
+        variables: {input: {name: 'repo-name', ownerId: 'user0', visibility: 'PUBLIC'}},
+      }, op => {
+        return relayResponseBuilder(op)
+          .createRepository(m => {
+            m.repository(r => {
+              r.sshUrl('[email protected]:user0/repo-name.git');
+              r.url('https://github.com/user0/repo-name');
+            });
+          })
+          .build();
+      }).resolve();
+
+      const empty = await buildRepository(temp.mkdirSync());
+      assert.isTrue(empty.isEmpty());
+
+      sinon.stub(empty, 'addRemote').resolves(CREATED_REMOTE);
+      sinon.stub(empty, 'push');
+
+      await publishRepository({
+        ownerID: 'user0',
+        name: 'repo-name',
+        visibility: 'PUBLIC',
+        protocol: 'https',
+        sourceRemoteName: 'origin',
+      }, {repository: empty, relayEnvironment});
+
+      assert.isTrue(empty.isPresent());
+      assert.isTrue(empty.addRemote.calledWith('origin', 'https://github.com/user0/repo-name'));
+      assert.isFalse(empty.push.called);
+    });
+
     it('fails if the source repository has no "master" or current branches', async function() {
       await repository.checkout('other-branch', {createNew: true});
       await repository.checkout('HEAD^');