Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Commit 96158c2

Browse files
committed
Use 'Nan::Set'
Fix the following errors. ``` ../src/main.cc:138:25: error: no matching member function for call to 'Set' misspelled_range->Set(Nan::New("end").ToLocalChecked(), Nan::New<Integer>(end)); ```
1 parent a03caf3 commit 96158c2

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

src/main.cc

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -134,9 +134,9 @@ class Spellchecker : public Nan::ObjectWrap {
134134
uint32_t start = iter->start, end = iter->end;
135135

136136
Local<Object> misspelled_range = Nan::New<Object>();
137-
misspelled_range->Set(Nan::New("start").ToLocalChecked(), Nan::New<Integer>(start));
138-
misspelled_range->Set(Nan::New("end").ToLocalChecked(), Nan::New<Integer>(end));
139-
result->Set(index, misspelled_range);
137+
Nan::Set(misspelled_range, Nan::New("start").ToLocalChecked(), Nan::New<Integer>(start));
138+
Nan::Set(misspelled_range, Nan::New("end").ToLocalChecked(), Nan::New<Integer>(end));
139+
Nan::Set(result, index, misspelled_range);
140140
}
141141
}
142142

@@ -220,7 +220,7 @@ class Spellchecker : public Nan::ObjectWrap {
220220
Local<Array> result = Nan::New<Array>(dictionaries.size());
221221
for (size_t i = 0; i < dictionaries.size(); ++i) {
222222
const std::string& dict = dictionaries[i];
223-
result->Set(i, Nan::New(dict.data(), dict.size()).ToLocalChecked());
223+
Nan::Set(result, i, Nan::New(dict.data(), dict.size()).ToLocalChecked());
224224
}
225225

226226
info.GetReturnValue().Set(result);
@@ -246,7 +246,7 @@ class Spellchecker : public Nan::ObjectWrap {
246246
const std::string& word = corrections[i];
247247

248248
Nan::MaybeLocal<String> val = Nan::New<String>(word.data(), word.size());
249-
result->Set(i, val.ToLocalChecked());
249+
Nan::Set(result, i, val.ToLocalChecked());
250250
}
251251

252252
info.GetReturnValue().Set(result);
@@ -286,7 +286,7 @@ class Spellchecker : public Nan::ObjectWrap {
286286

287287
Isolate* isolate = exports->GetIsolate();
288288
Local<Context> context = isolate->GetCurrentContext();
289-
exports->Set(Nan::New("Spellchecker").ToLocalChecked(), tpl->GetFunction(context).ToLocalChecked());
289+
Nan::Set(exports, Nan::New("Spellchecker").ToLocalChecked(), tpl->GetFunction(context).ToLocalChecked());
290290
}
291291
};
292292

src/worker.cc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,9 @@ void CheckSpellingWorker::HandleOKCallback() {
3535
uint32_t start = iter->start, end = iter->end;
3636

3737
Local<Object> misspelled_range = Nan::New<Object>();
38-
misspelled_range->Set(Nan::New("start").ToLocalChecked(), Nan::New<Integer>(start));
39-
misspelled_range->Set(Nan::New("end").ToLocalChecked(), Nan::New<Integer>(end));
40-
result->Set(index, misspelled_range);
38+
Nan::Set(misspelled_range, Nan::New("start").ToLocalChecked(), Nan::New<Integer>(start));
39+
Nan::Set(misspelled_range, Nan::New("end").ToLocalChecked(), Nan::New<Integer>(end));
40+
Nan::Set(result, index, misspelled_range);
4141
}
4242

4343
Local<Value> argv[] = { Nan::Null(), result };

0 commit comments

Comments
 (0)