Merge pull request #1 from bendemboski/fix-pre-node-12

Build for older and newer version of v8

Author: goddessfreya

package-lock.json

@@ -134,6 +134,8 @@ class Spellchecker : public Nan::ObjectWrap {
       uint32_t start = iter->start, end = iter->end;
 
       Local<Object> misspelled_range = Nan::New<Object>();
+
+#ifdef V8_USE_MAYBE
       {
         Isolate* isolate = misspelled_range->GetIsolate();
         Local<Context> context = isolate->GetCurrentContext();
@@ -143,6 +145,11 @@ class Spellchecker : public Nan::ObjectWrap {
       Isolate* isolate = result->GetIsolate();
       Local<Context> context = isolate->GetCurrentContext();
       result->Set(context, index, misspelled_range).Check();
+#else
+      misspelled_range->Set(Nan::New("start").ToLocalChecked(), Nan::New<Integer>(start));
+      misspelled_range->Set(Nan::New("end").ToLocalChecked(), Nan::New<Integer>(end));
+      result->Set(index, misspelled_range);
+#endif
     }
   }
 
@@ -226,9 +233,13 @@ class Spellchecker : public Nan::ObjectWrap {
     Local<Array> result = Nan::New<Array>(dictionaries.size());
     for (size_t i = 0; i < dictionaries.size(); ++i) {
       const std::string& dict = dictionaries[i];
+#ifdef V8_USE_MAYBE
       Isolate* isolate = result->GetIsolate();
       Local<Context> context = isolate->GetCurrentContext();
       result->Set(context, i, Nan::New(dict.data(), dict.size()).ToLocalChecked()).Check();
+#else
+      result->Set(i, Nan::New(dict.data(), dict.size()).ToLocalChecked());
+#endif
     }
 
     info.GetReturnValue().Set(result);
@@ -254,9 +265,13 @@ class Spellchecker : public Nan::ObjectWrap {
       const std::string& word = corrections[i];
 
       Nan::MaybeLocal<String> val = Nan::New<String>(word.data(), word.size());
+#ifdef V8_USE_MAYBE
       Isolate* isolate = result->GetIsolate();
       Local<Context> context = isolate->GetCurrentContext();
       result->Set(context, i, val.ToLocalChecked()).Check();
+#else
+      result->Set(i, val.ToLocalChecked());
+#endif
     }
 
     info.GetReturnValue().Set(result);
@@ -296,7 +311,11 @@ class Spellchecker : public Nan::ObjectWrap {
 
     Isolate* isolate = exports->GetIsolate();
     Local<Context> context = isolate->GetCurrentContext();
+#ifdef V8_USE_MAYBE
     exports->Set(context, Nan::New("Spellchecker").ToLocalChecked(), tpl->GetFunction(context).ToLocalChecked()).Check();
+#else
+    exports->Set(Nan::New("Spellchecker").ToLocalChecked(), tpl->GetFunction(context).ToLocalChecked());
+#endif
   }
 };
 

src/main.cc

@@ -6,6 +6,10 @@
 #include <memory>
 #include <stdint.h>
 
+#if V8_MAJOR_VERSION > 6 && V8_MINOR_VERSION > 2
+#define V8_USE_MAYBE
+#endif
+
 namespace spellchecker {
 
 const int USE_SYSTEM_DEFAULTS = 0;

src/spellchecker.h

@@ -35,6 +35,7 @@ void CheckSpellingWorker::HandleOKCallback() {
     uint32_t start = iter->start, end = iter->end;
 
     Local<Object> misspelled_range = Nan::New<Object>();
+#ifdef V8_USE_MAYBE
     {
       Isolate* isolate = misspelled_range->GetIsolate();
       Local<Context> context = isolate->GetCurrentContext();
@@ -44,6 +45,11 @@ void CheckSpellingWorker::HandleOKCallback() {
     Isolate* isolate = result->GetIsolate();
     Local<Context> context = isolate->GetCurrentContext();
     result->Set(context, index, misspelled_range).Check();
+#else
+    misspelled_range->Set(Nan::New("start").ToLocalChecked(), Nan::New<Integer>(start));
+    misspelled_range->Set(Nan::New("end").ToLocalChecked(), Nan::New<Integer>(end));
+    result->Set(index, misspelled_range); 
+#endif
   }
 
   Local<Value> argv[] = { Nan::Null(), result };