Does not handle searching for multiline regex's

[benogle]

PathSearcher runs the regex on each line, not on the text as a whole. So something like [a-z]+\n[0-9]+ will not be matched.

This was a design decision for efficiency. We only need to have each line, not the whole file. Right now the file reader only reads 10k at a time, and searches on the lines returned.

I'm not sure how to handle multiline regexs efficiently. How to make it handle a 100MB file? I'm opening this for discussion. As I build out the PathReplacer, it will have the same limitation.

One approach could be to:

1. set buffer = ''
2. read 10k chunk, append it onto buffer
3. run the regex buffer
4. if match: buffer = buffer.slice(match.end)
5. goto 2

But on files with no match, it will read the entire file into memory.

[jonhatalla]

This would be a really useful feature, Is the PathSearcher object interchangable?

[benogle]

Yeah, it can be. We can subclass it or something. Really, the thing that needs to change is the way we read the file.

Was thinking of checking the regex for multiline search and then running a different codepath that handles multiline.

[jacobfike]

+1 for different handlers, as not being able to search for \n at all is a huge pain. I am ok with complicated regex searches taking longer.

[furins]

+1 for different handlers as well

[ShimShamSam]

+1

[benkelaar]

+1

[luccamordente]

+1

[tomek-he-him]

Multiline search/replace is a crucial feature for me – as well as for many other devs, I guess. I’m on the verge of switching from Sublime to Atom – and this is the biggest thing holding me back.

[Phylodome]

👍

[dyoji]

+1