This repository was archived by the owner on Dec 15, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 277
marked 1.2.9 might be incompatible #1189
Copy link
Copy link
Open
Description
Prerequisites
- Put an X between the brackets on this line if you have done all of the following:
- Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
- Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
- Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
- Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
- Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages
Description
In atom/atom#22717, using marked version 1.2.0 worked, but 1.2.9 doesn't.
The fail appears to be from here:

Therefore the current version range ^1.2.0 includes the incompatible version 1.2.9.
Maybe it should read 1.2.0 instead, but ideally more tests with different versions would be done to see the actual range of compatibility
Line 27 in d474e70
| "marked": "^1.2.0", |
Steps to Reproduce
Expected behavior:
Marked 1.2.9 works
Actual behavior:
It fails
Reproduces how often:
2/2
Versions
Atom uses settings-view v0.261.8
The tests (see atom/atom#22717 (comment)) only fail in MacOS. Weird.
Additional Information
Metadata
Metadata
Assignees
Labels
No labels