Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

marked 1.2.9 might be incompatible #1189

@icecream17

Description

@icecream17

Prerequisites

Description

In atom/atom#22717, using marked version 1.2.0 worked, but 1.2.9 doesn't.

The fail appears to be from here:
image

Therefore the current version range ^1.2.0 includes the incompatible version 1.2.9.
Maybe it should read 1.2.0 instead, but ideally more tests with different versions would be done to see the actual range of compatibility

"marked": "^1.2.0",

Steps to Reproduce

Expected behavior:

Marked 1.2.9 works

Actual behavior:

It fails

Reproduces how often:

2/2

Versions

Atom uses settings-view v0.261.8

The tests (see atom/atom#22717 (comment)) only fail in MacOS. Weird.

Additional Information

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions