Adding a test for checkers that do not provide suggest

Author: dmoonfire

lib/corrections-view.js

@@ -44,12 +44,10 @@ export default class CorrectionsView {
                             this.editor.buffer.file &&
                             this.editor.buffer.file.path
                         ) {
-                            [
-                                projectPath,
-                                relativePath,
-                            ] = atom.project.relativizePath(
-                                this.editor.buffer.file.path
-                            );
+                            [projectPath, relativePath] =
+                                atom.project.relativizePath(
+                                    this.editor.buffer.file.path
+                                );
                         }
 
                         const args = { id: this.id, projectPath, relativePath };

lib/spell-check-manager.js

@@ -317,6 +317,15 @@ class SpellCheckerManager {
                 continue;
             }
 
+            // Do a little sanity checking.
+            if (!checker.suggest) {
+                this.log(
+                    'spell checker does not have a .suggest function',
+                    checker
+                );
+                continue;
+            }
+
             // Get the suggestions for this word.
             index = 0;
             priority = checker.getPriority();

lib/spell-check-view.js

@@ -24,7 +24,8 @@ module.exports = SpellCheckView = class SpellCheckView {
                 let marker;
                 if (
                     (marker = this.markerLayer.findMarkers({
-                        containsBufferPosition: this.editor.getCursorBufferPosition(),
+                        containsBufferPosition:
+                            this.editor.getCursorBufferPosition(),
                     })[0])
                 ) {
                     if (CorrectionsView == null) {
@@ -202,9 +203,8 @@ module.exports = SpellCheckView = class SpellCheckView {
         const currentScreenPosition = atom.views
             .getView(this.editor)
             .component.screenPositionForMouseEvent(mouseEvent);
-        const currentBufferPosition = this.editor.bufferPositionForScreenPosition(
-            currentScreenPosition
-        );
+        const currentBufferPosition =
+            this.editor.bufferPositionForScreenPosition(currentScreenPosition);
 
         // Check to see if the selected word is incorrect.
         if (

spec/spell-check-spec.js

@@ -241,9 +241,8 @@ describe('Spell check', function () {
                     editorElement,
                     'spell-check:correct-misspelling'
                 );
-                correctionsElement = editorElement.querySelector(
-                    '.corrections'
-                );
+                correctionsElement =
+                    editorElement.querySelector('.corrections');
                 expect(correctionsElement).toBeDefined();
                 expect(
                     correctionsElement.querySelectorAll('li').length