Skip to content

Commit d6f82b2

Browse files
committed
Minor changes I forgot to change back
1 parent 418d307 commit d6f82b2

File tree

4 files changed

+5
-15
lines changed

4 files changed

+5
-15
lines changed

browser/data-browser/src/views/TablePage/EditorCells/JSONCell.tsx

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,15 +47,11 @@ function JSONCellEdit({
4747

4848
useCellOptions(options);
4949

50-
const openDialog = () => {
51-
show();
52-
};
53-
5450
const displayValue = JSON.stringify(value);
5551

5652
return (
5753
<>
58-
<IconButton title='Open edit dialog' onClick={openDialog} autoFocus>
54+
<IconButton title='Open edit dialog' onClick={show} autoFocus>
5955
<FaPencil />
6056
</IconButton>
6157
<div>{displayValue}</div>

browser/data-browser/src/views/TablePage/EditorCells/MarkdownCell.tsx

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,13 +47,9 @@ function MarkdownCellEdit({
4747

4848
useCellOptions(options);
4949

50-
const openDialog = () => {
51-
show();
52-
};
53-
5450
return (
5551
<>
56-
<IconButton title='Open edit dialog' onClick={openDialog} autoFocus>
52+
<IconButton title='Open edit dialog' onClick={show} autoFocus>
5753
<FaPencil />
5854
</IconButton>
5955
<div>{value as string}</div>

browser/e2e/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
"test-update": "playwright test --update-snapshots",
2626
"test-new": "playwright codegen http://localhost:5173",
2727
"test-query": "DELETE_PREVIOUS_TEST_DRIVES=false playwright test -g",
28-
"test-ui": "DELETE_PREVIOUS_TEST_DRIVES=false playwright test --ui"
28+
"test-ui": "playwright test --ui"
2929
},
3030
"dependencies": {}
3131
}

browser/e2e/tests/test-utils.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,8 @@ export const PROPERTIES = {
1010
export const DELETE_PREVIOUS_TEST_DRIVES =
1111
process.env.DELETE_PREVIOUS_TEST_DRIVES === 'false' ? false : true;
1212

13-
export const SERVER_URL =
14-
process.env.SERVER_URL || 'http://localhost-atomic:9883';
15-
export const FRONTEND_URL =
16-
process.env.FRONTEND_URL || 'http://localhost-atomic:9883';
13+
export const SERVER_URL = process.env.SERVER_URL || 'http://localhost:9883';
14+
export const FRONTEND_URL = process.env.FRONTEND_URL || 'http://localhost:5173';
1715
const startDriveName = new URL(FRONTEND_URL).hostname;
1816

1917
// TODO: Should use an env var so the CI can test the setup test.

0 commit comments

Comments
 (0)