Improve invite error handling

Author: joepio

browser/data-browser/src/App.tsx

@@ -6,9 +6,11 @@ import { getAgentFromLocalStorage } from './helpers/agentStorage';
 import { registerCustomCreateActions } from './components/forms/NewForm/CustomCreateActions';
 import { serverURLStorage } from './helpers/serverURLStorage';
 
-import type { JSX } from 'react';
+import { useEffect, type JSX } from 'react';
 import { RouterProvider } from '@tanstack/react-router';
 import { router } from './routes/Router';
+import { errorHandler } from './handlers/errorHandler';
+import { error } from 'node:console';
 
 function fixDevUrl(url: string) {
   if (isDev()) {
@@ -54,6 +56,17 @@ if (isDev()) {
 
 /** Entrypoint of the application. This is where providers go. */
 function App(): JSX.Element {
+  // Handle uncaught errors
+  useEffect(() => {
+    window.onerror = (message, source, lineno, colno, error) => {
+      errorHandler(error);
+    };
+
+    window.onunhandledrejection = event => {
+      errorHandler(event.reason);
+    };
+  }, []);
+
   return (
     <StoreContext.Provider value={store}>
       <RouterProvider router={router}></RouterProvider>

browser/data-browser/src/views/InvitePage.tsx

@@ -24,6 +24,7 @@ import type { JSX } from 'react';
 import { useNavigateWithTransition } from '../hooks/useNavigateWithTransition';
 import { useNavState } from '../components/NavState';
 import { toast } from 'react-hot-toast';
+import { errorHandler } from '../handlers/errorHandler';
 
 /** A View that opens an invite */
 function InvitePage({ resource }: ResourcePageProps): JSX.Element {
@@ -40,11 +41,15 @@ function InvitePage({ resource }: ResourcePageProps): JSX.Element {
   // When this happens, a new keypair is made, but the subject of the Agent is not yet known.
   // It will be created by the server, and will be accessible in the Redirect response.
   async function handleNew() {
-    const keypair = await generateKeyPair();
-    const newAgent = new Agent(keypair.privateKey);
+    try {
+      const keypair = await generateKeyPair();
+      const newAgent = new Agent(keypair.privateKey);
 
-    setAgent(newAgent);
-    handleAccept(keypair);
+      setAgent(newAgent);
+      handleAccept(keypair);
+    } catch (error) {
+      store.notifyError(error);
+    }
   }
 
   const handleAccept = async (keys?: {
@@ -61,7 +66,17 @@ function InvitePage({ resource }: ResourcePageProps): JSX.Element {
 
     const redirect = await store.getResource<Server.Redirect>(inviteURL.href);
 
-    if (redirect.props.redirectAgent && keys) {
+    if (keys) {
+      if (redirect.error) {
+        store.notifyError(redirect.error);
+
+        return;
+      }
+
+      if (!redirect.props.redirectAgent) {
+        throw new Error('Redirect agent not found');
+      }
+
       const newAgent = new Agent(keys.privateKey, redirect.props.redirectAgent);
       setAgent(newAgent);
 

lib/src/plugins/invite.rs

@@ -68,6 +68,10 @@ pub fn construct_invite_redirect(
         })?
         .to_string();
 
+    store
+        .get_resource(target)
+        .map_err(|e| format!("Target for invite does not exist: {}", target))?;
+
     // If any usages left value is present, make sure it's a positive number and decrement it by 1.
     if let Ok(usages_left) = invite_resource.get(urls::USAGES_LEFT) {
         let num = usages_left.to_int()?;