move some stuff to utils and write some tests

Author: atomicptr

src/mobdap/handler.clj

@@ -7,6 +7,7 @@
    [clojure.string :as string]
    [mobdap.adapter :as adapter]
    [mobdap.debug-server :as debug-server]
+   [mobdap.utils :refer [float-to-string map-over-map to-int]]
    [taoensso.timbre :as log]))
 
 (def ^:private go-handler (atom nil))
@@ -25,11 +26,6 @@
    :stackframes  (atom [])
    :var-index    (atom {})})
 
-(defn- to-int [value]
-  (if (int? value)
-    value
-    (Integer/parseInt value)))
-
 (defn- find-source-dir [handler filepath]
   (let [file (io/file filepath)]
     (cond
@@ -156,9 +152,6 @@
     (adapter/send-message! (:adapter handler) response)
     handler))
 
-(defn- map-over-map [fun m]
-  (reduce-kv (fn [m k v] (assoc m k (fun k v))) {} m))
-
 (defn- parse-heap-value [ident]
   (when-let [[_ type addr] (re-find #"(.+):\s*(0x[A-Za-z0-9]+)" ident)]
     {:type (keyword type)
@@ -402,9 +395,6 @@
            (get-in m [:extras :upvalues]))))
    data))
 
-(defn- float-to-string [n]
-  (.replaceAll (format "%.16f" n) "\\.?0*$" ""))
-
 (defn- var-name [n]
   (cond
     (keyword? n) (name n)

src/mobdap/utils.clj

@@ -0,0 +1,12 @@
+(ns mobdap.utils)
+
+(defn to-int [value]
+  (if (int? value)
+    value
+    (Integer/parseInt value)))
+
+(defn map-over-map [fun m]
+  (reduce-kv (fn [m k v] (assoc m k (fun k v))) {} m))
+
+(defn float-to-string [n]
+  (.replaceAll (format "%.16f" n) "\\.?0*$" ""))

test/mobdap/utils_test.clj

@@ -0,0 +1,21 @@
+(ns mobdap.utils-test
+  (:require
+   [clojure.test :refer [deftest is testing]]
+   [mobdap.utils :refer [float-to-string map-over-map to-int]]))
+
+(deftest test-to-int
+  (testing "int just returns as is"
+    (is (= 1337 (to-int 1337))))
+  (testing "strings convert properly"
+    (is (= 42 (to-int "42")))))
+
+(deftest test-map-over-map
+  (testing "square every item"
+    (is (match? {:a 1 :b 4 :c 9 :d 16} (map-over-map #(* %2 %2) {:a 1 :b 2 :c 3 :d 4}))))
+  (testing "turn value to key"
+    (is (match? {:a :a :b :b :c :c} (map-over-map (fn [k _] k) {:a 1 :b 2 :c 3})))))
+
+(deftest test-float-to-string
+  (testing "make nice looking float strings"
+    (is "1.337" (float-to-string 1.337))))
+