Skip to content
This repository was archived by the owner on Nov 9, 2024. It is now read-only.

Commit 3c5d555

Browse files
committed
fix(types): strict types for plugins
Since [email protected]
1 parent b7b78a0 commit 3c5d555

File tree

3 files changed

+7
-25
lines changed

3 files changed

+7
-25
lines changed

index.d.ts

Lines changed: 3 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,47 +1,29 @@
11
import * as React from 'react';
22
import {default as tippyCore, Instance, Props, Plugin} from 'tippy.js';
33

4-
type KnownKeys<T> = {
5-
[K in keyof T]: string extends K ? never : number extends K ? never : K;
6-
} extends {[_ in keyof T]: infer U}
7-
? U
8-
: never;
9-
10-
export type KnownProps = Pick<Props, KnownKeys<Props>>;
11-
12-
export interface TippyProps extends Omit<Partial<KnownProps>, 'content'> {
4+
export interface TippyProps extends Omit<Partial<Props>, 'content'> {
135
content: React.ReactChild | React.ReactChild[];
146
children: React.ReactElement<any>;
157
visible?: boolean;
168
enabled?: boolean;
179
className?: string;
1810
singleton?: (instance: Instance) => void;
19-
[key: string]: any;
2011
}
2112

2213
declare const Tippy: React.ForwardRefExoticComponent<TippyProps>;
2314
export default Tippy;
2415

2516
export const tippy: typeof tippyCore;
2617

27-
export interface TippySingletonProps extends Partial<KnownProps> {
18+
export interface TippySingletonProps extends Partial<Props> {
2819
children: Array<React.ReactElement<any>>;
2920
enabled?: boolean;
3021
className?: string;
31-
[key: string]: any;
3222
}
3323

3424
export const TippySingleton: React.FunctionComponent<TippySingletonProps>;
3525

36-
type KnownSingletonProps = Pick<
37-
TippySingletonProps,
38-
KnownKeys<TippySingletonProps>
39-
>;
40-
41-
export interface UseSingletonProps
42-
extends Omit<KnownSingletonProps, 'children'> {
43-
[key: string]: any;
44-
}
26+
export type UseSingletonProps = Omit<TippySingletonProps, 'children'>;
4527

4628
export const useSingleton: (
4729
props?: UseSingletonProps,

package-lock.json

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
},
5252
"dependencies": {
5353
"prop-types": "^15.6.2",
54-
"tippy.js": "^5.1.0"
54+
"tippy.js": "^5.1.1"
5555
},
5656
"peerDependencies": {
5757
"react": ">=16.8",

0 commit comments

Comments
 (0)