fix: unique util (#292)

Author: atomiks

src/Tippy.js

@@ -141,16 +141,6 @@ export default function TippyGenerator(tippy) {
 
       const {instance} = mutableBox;
 
-      if (
-        instance.props.popperOptions?.modifiers?.find(
-          i => i.name === '$$tippyReact',
-        )
-      ) {
-        console.log(
-          deepPreserveProps(instance.props, computedProps).popperOptions,
-        );
-      }
-
       instance.setProps(deepPreserveProps(instance.props, computedProps));
 
       // Fixes #264

src/utils.js

@@ -32,17 +32,16 @@ export function toDataAttributes(attrs) {
   return dataAttrs;
 }
 
-export function uniqueByName(arrNaturalOrder) {
+export function uniqueByShape(arr) {
   const output = [];
   const lookup = Object.create(null);
-  const arr = arrNaturalOrder.reverse();
 
-  for (const item in arr) {
-    if (lookup[arr[item].name] === undefined) {
-      output.push(arr[item]);
+  arr.forEach(item => {
+    if (lookup[JSON.stringify(item)] === undefined) {
+      output.push(item);
     }
-    lookup[arr[item].name] = arr[item];
-  }
+    lookup[JSON.stringify(item)] = true;
+  });
 
   return output;
 }
@@ -53,7 +52,7 @@ export function deepPreserveProps(instanceProps, componentProps) {
     popperOptions: {
       ...instanceProps.popperOptions,
       ...componentProps.popperOptions,
-      modifiers: uniqueByName([
+      modifiers: uniqueByShape([
         ...(instanceProps.popperOptions?.modifiers || []),
         ...(componentProps.popperOptions?.modifiers || []),
       ]),

test/utils.test.js

@@ -0,0 +1,18 @@
+import {uniqueByShape} from '../src/utils';
+
+describe('uniqueByShape', () => {
+  it('filters duplicates', () => {
+    expect(
+      uniqueByShape([
+        {name: 'hello'},
+        {name: 'hello'},
+        {name: 'hello', enabled: false},
+        {name: 'hello2'},
+      ]),
+    ).toEqual([
+      {name: 'hello'},
+      {name: 'hello', enabled: false},
+      {name: 'hello2'},
+    ]);
+  });
+});