Skip to content

Commit 2ead548

Browse files
author
Chris Bellew
committed
Filter out some extraneous stuff from error messages. Fixed bug that crashed when no network connection exists.
1 parent 9fe5762 commit 2ead548

File tree

3 files changed

+19
-11
lines changed

3 files changed

+19
-11
lines changed

Voice Control For Plex/src/main/java/com/atomjack/vcfp/Feedback.java

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -103,16 +103,16 @@ private void feedback(String text, boolean errors, boolean forceToast) {
103103
// The text will be spoken when the tts is finished setting up (in onInit)
104104
if (errors) {
105105
errorsTts = new TextToSpeech(context, this);
106-
errorsQueue = text;
106+
errorsQueue = filterText(text);
107107
errorsTts.setOnUtteranceProgressListener(utteranceProgressListener);
108108
} else {
109109
feedbackTts = new TextToSpeech(context, this);
110-
feedbackQueue = text;
110+
feedbackQueue = filterText(text);
111111
feedbackTts.setOnUtteranceProgressListener(utteranceProgressListener);
112112
}
113113
} else {
114114
map.put(TextToSpeech.Engine.KEY_PARAM_UTTERANCE_ID, Integer.toString(utteranceId++));
115-
tts.speak(text, TextToSpeech.QUEUE_FLUSH, map);
115+
tts.speak(filterText(text), TextToSpeech.QUEUE_FLUSH, map);
116116
if (errors)
117117
errorsQueue = null;
118118
else
@@ -126,6 +126,12 @@ private void feedback(String text, boolean errors, boolean forceToast) {
126126
}
127127
}
128128

129+
// Filter out some extraneous patterns, like when a connection is refused, strip out the uri.
130+
private String filterText(String text) {
131+
text = text.replaceAll("to https?://([0-9]+\\.){3}[0-9]+:[0-9]+ refused", " refused");
132+
return text;
133+
}
134+
129135
private UtteranceProgressListener utteranceProgressListener = new UtteranceProgressListener() {
130136
@Override
131137
public void onStart(String s) {

Voice Control For Plex/src/main/java/com/atomjack/vcfp/activities/CastActivity.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,17 +239,19 @@ public void doPlayPause(View v) {
239239
public void doRewind(View v) {
240240
if(position > -1) {
241241
nowPlayingMedia.viewOffset = Integer.toString(position - 15000);
242-
if(Integer.parseInt(nowPlayingMedia.viewOffset) < 0) {
242+
if (Integer.parseInt(nowPlayingMedia.viewOffset) < 0) {
243243
position = 0;
244244
nowPlayingMedia.viewOffset = "0";
245245
}
246246
castPlayerManager.seekTo(Integer.parseInt(nowPlayingMedia.viewOffset) / 1000);
247+
}
247248
}
248249

249250
public void doForward(View v) {
250251
if(position > -1) {
251252
nowPlayingMedia.viewOffset = Integer.toString(position + 30000);
252253
castPlayerManager.seekTo(Integer.parseInt(nowPlayingMedia.viewOffset) / 1000);
254+
}
253255
}
254256

255257
public void doStop(View v) {

Voice Control For Plex/src/main/java/com/atomjack/vcfp/activities/VCFPActivity.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -107,17 +107,17 @@ public enum NetworkState {
107107
MOBILE;
108108

109109
public static NetworkState getCurrentNetworkState(Context context) {
110-
NetworkState currentNetworkState;
110+
NetworkState currentNetworkState = NetworkState.DISCONNECTED;
111111
ConnectivityManager cm =
112112
(ConnectivityManager) context.getSystemService(Context.CONNECTIVITY_SERVICE);
113113

114114
NetworkInfo activeNetwork = cm.getActiveNetworkInfo();
115-
if(activeNetwork.getType() == ConnectivityManager.TYPE_MOBILE)
116-
currentNetworkState = NetworkState.MOBILE;
117-
else if(activeNetwork.getType() == ConnectivityManager.TYPE_WIFI)
118-
currentNetworkState = NetworkState.WIFI;
119-
else
120-
currentNetworkState = NetworkState.DISCONNECTED;
115+
if(activeNetwork != null) {
116+
if (activeNetwork.getType() == ConnectivityManager.TYPE_MOBILE)
117+
currentNetworkState = NetworkState.MOBILE;
118+
else if (activeNetwork.getType() == ConnectivityManager.TYPE_WIFI)
119+
currentNetworkState = NetworkState.WIFI;
120+
}
121121
return currentNetworkState;
122122
}
123123
};

0 commit comments

Comments
 (0)