Bug fix:client selector was reporting no clients found when a chromecast was present but no other plex clients were. Version bump for next beta. Added directive to ignore missing translations.

Author: Chris Bellew

Voice Control For Plex/src/main/AndroidManifest.xml

@@ -2,8 +2,8 @@
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
           xmlns:tools="http://schemas.android.com/tools"
     package="com.atomjack.vcfp"
-    android:versionCode="22"
-    android:versionName="1.9.0b3" >
+    android:versionCode="23"
+    android:versionName="1.9.0b4" >
 
     <uses-permission android:name="com.mohammadag.googlesearchapi.permission.ACCESS_GGOGLE_SEARCH_API" />
     <uses-permission android:name="android.permission.INTERNET" />

Voice Control For Plex/src/main/java/com/atomjack/vcfp/activities/MainActivity.java

@@ -787,11 +787,12 @@ public void onClick(DialogInterface dialog, int id) {
         }
       } else if(intent.getStringExtra(VoiceControlForPlexApplication.Intent.SCAN_TYPE).equals(VoiceControlForPlexApplication.Intent.SCAN_TYPE_CLIENT)) {
         ArrayList<PlexClient> clients = intent.getParcelableArrayListExtra(VoiceControlForPlexApplication.Intent.EXTRA_CLIENTS);
-        if(clients != null) {
+        if(clients != null || VoiceControlForPlexApplication.getInstance().castClients.size() > 0) {
           VoiceControlForPlexApplication.clients = new HashMap<String, PlexClient>();
-          for (PlexClient c : clients) {
-            VoiceControlForPlexApplication.clients.put(c.name, c);
-          }
+          if(clients != null)
+            for (PlexClient c : clients) {
+              VoiceControlForPlexApplication.clients.put(c.name, c);
+            }
           VoiceControlForPlexApplication.getInstance().prefs.put(Preferences.SAVED_CLIENTS, gsonWrite.toJson(VoiceControlForPlexApplication.clients));
           boolean showConnectToClients = intent.getBooleanExtra(VoiceControlForPlexApplication.Intent.EXTRA_CONNECT_TO_CLIENT, false);
           Logger.d("showConnectToClients: %s", showConnectToClients);

Voice Control For Plex/src/main/res/values-es/strings.xml

@@ -1,4 +1,6 @@
-<resources>
+<resources
+    xmlns:tools="http://schemas.android.com/tools"
+    tools:ignore="MissingTranslation">
     <string name="app_name">Voice Control for Plex</string>
     <string name="action_settings">Ajustes</string>
     <string name="ok">OK</string>

Voice Control For Plex/src/main/res/values-fr/strings.xml

@@ -1,4 +1,6 @@
-<resources>
+<resources
+    xmlns:tools="http://schemas.android.com/tools"
+    tools:ignore="MissingTranslation">
     <string name="app_name">Voice Control for Plex</string>
     <string name="action_settings">Paramètres</string>
     <string name="ok">OK</string>