Default to Manual Login when attempting to fetch a pin code fails.

Author: Chris Bellew

mobile/src/main/java/com/atomjack/vcfp/activities/MainActivity.java

@@ -815,7 +815,7 @@ public void onSuccess(Pin pin) {
       @Override
       public void onFailure(Throwable error) {
         error.printStackTrace();
-        feedback.e(R.string.login_error);
+        showManualLogin(true);
       }
     });
   }
@@ -923,13 +923,21 @@ private void showFindingPlexClientsAndServers() {
   }
 
   private void showManualLogin() {
+    showManualLogin(false);
+  }
+
+  private void showManualLogin(boolean showPinError) {
     LayoutInflater layoutInflater = LayoutInflater.from(MainActivity.this);
     View view = layoutInflater.inflate(R.layout.login, null);
     AlertDialog.Builder builder = new AlertDialog.Builder(MainActivity.this);
     builder.setView(view);
     final EditText usernameInput = (EditText) view.findViewById(R.id.usernameInput);
     final EditText passwordInput = (EditText) view.findViewById(R.id.passwordInput);
 
+    if(showPinError) {
+      TextView loginPinError = (TextView) view.findViewById(R.id.loginPinError);
+      loginPinError.setVisibility(View.VISIBLE);
+    }
     final AlertDialog alertD = builder.create();
 
     Button popupManualLoginPinButton = (Button)view.findViewById(R.id.popupManualLoginPinButton);

mobile/src/main/java/com/atomjack/vcfp/net/PlexHttpClient.java

@@ -530,7 +530,10 @@ public static void getPinCode(final PlexPinResponseHandler responseHandler) {
     call.enqueue(new Callback<Pin>() {
       @Override
       public void onResponse(Response<Pin> response) {
-        responseHandler.onSuccess(response.body());
+        if(response.code() == 200 || response.code() == 201)
+          responseHandler.onSuccess(response.body());
+        else
+          responseHandler.onFailure(new Throwable());
       }
 
       @Override

mobile/src/main/res/layout/login.xml

@@ -74,4 +74,14 @@
             android:layout_alignParentEnd="true"/>
     </RelativeLayout>
 
+    <TextView
+        android:layout_width="wrap_content"
+        android:layout_height="wrap_content"
+        android:textAppearance="?android:attr/textAppearanceMedium"
+        android:text="@string/pin_popup_error"
+        android:id="@+id/loginPinError"
+        android:layout_marginTop="10dp"
+        android:textColor="@color/white"
+        android:visibility="gone"/>
+
 </LinearLayout>

mobile/src/main/res/values/strings.xml

@@ -199,6 +199,7 @@
     <string name="localmedia_purchase_from_menu">If you would like to unlock this feature in the future, you can purchase it via the Settings portion of the Navigation Menu.</string>
     <string name="localmedia_purchase_reminder">Playback to the local device is restricted to one minute. Would you like to unlock it(%s)?</string>
     <string name="purchase_localmedia">Purchase Local Media Playback</string>
+    <string name="pin_popup_error">An error was encountered attempting to request a Pin code from plex.tv.</string>
 
     <!-- Tutorial time! -->
     <string name="tutorial1_cast_button">Tap the cast icon to select a Plex client.</string>