Merge pull request #737 from pguyot/w31/fix-more-types

Fix more types and few examples

Running dialyzer on atomvmlib and examples revealed issues with several types
It also revealed bugs in three examples

These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).

SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later

Author: bettio

examples/erlang/esp32/ap_sta_network.erl

@@ -36,7 +36,7 @@ start() ->
             {sta_connected, fun sta_connected/1},
             {sta_ip_assigned, fun sta_ip_assigned/1},
             {sta_disconnected, fun sta_disconnected/1},
-            {ap_sta_ip_assigned, fun ap_sta_ip_assigned/1}
+            {sta_ip_assigned, fun ap_sta_ip_assigned/1}
         ]},
         {sta, [
             {ssid, <<"myssid">>},

examples/erlang/hello_world_server.erl

@@ -33,8 +33,8 @@ start() ->
             {disconnected, fun() -> Self ! disconnected end}
         ]}
     ],
-    case network_fsm:start(Config) of
-        ok ->
+    case network:start(Config) of
+        {ok, _Pid} ->
             wait_for_message();
         Error ->
             io:format("An error occurred starting network: ~p~n", [Error])

examples/erlang/system_info_server.erl

@@ -33,8 +33,8 @@ start() ->
             {disconnected, fun() -> Self ! disconnected end}
         ]}
     ],
-    case network_fsm:start(Config) of
-        ok ->
+    case network:start(Config) of
+        {ok, _Pid} ->
             wait_for_message();
         Error ->
             io:format("An error occurred starting network: ~p~n", [Error])

libs/eavmlib/src/atomvm.erl

@@ -38,7 +38,9 @@
 
 -type platform_name() ::
     generic_unix
+    | emscripten
     | esp32
+    | pico
     | stm32.
 
 -type avm_path() :: string() | binary().
@@ -52,7 +54,7 @@
 %%-----------------------------------------------------------------------------
 -spec platform() -> platform_name().
 platform() ->
-    throw(nif_error).
+    erlang:nif_error(undefined).
 
 %%-----------------------------------------------------------------------------
 %% @returns random 32-bit integer.
@@ -63,7 +65,7 @@ platform() ->
 %%-----------------------------------------------------------------------------
 -spec random() -> integer().
 random() ->
-    throw(nif_error).
+    erlang:nif_error(undefined).
 
 %%-----------------------------------------------------------------------------
 %% @param   Len non-negative integer
@@ -76,7 +78,7 @@ random() ->
 %%-----------------------------------------------------------------------------
 -spec rand_bytes(Len :: non_neg_integer()) -> binary().
 rand_bytes(_Len) ->
-    throw(nif_error).
+    erlang:nif_error(undefined).
 
 %%-----------------------------------------------------------------------------
 %% @param   App application name.
@@ -87,7 +89,7 @@ rand_bytes(_Len) ->
 %%-----------------------------------------------------------------------------
 -spec read_priv(App :: atom(), Path :: list()) -> binary().
 read_priv(_App, _Path) ->
-    throw(nif_error).
+    erlang:nif_error(undefined).
 
 %%-----------------------------------------------------------------------------
 %% @param   AVMData AVM data.
@@ -104,7 +106,7 @@ read_priv(_App, _Path) ->
 %%-----------------------------------------------------------------------------
 -spec add_avm_pack_binary(AVMData :: binary(), Options :: [{name, Name :: atom()}]) -> ok.
 add_avm_pack_binary(_AVMData, _Options) ->
-    throw(nif_error).
+    erlang:nif_error(undefined).
 
 %%-----------------------------------------------------------------------------
 %% @param   AVMPath Path to AVM data.
@@ -131,7 +133,7 @@ add_avm_pack_binary(_AVMData, _Options) ->
 %%-----------------------------------------------------------------------------
 -spec add_avm_pack_file(AVMPath :: avm_path(), Options :: []) -> ok.
 add_avm_pack_file(_AVMPath, _Options) ->
-    throw(nif_error).
+    erlang:nif_error(undefined).
 
 %%-----------------------------------------------------------------------------
 %% @param   name the AVM name.
@@ -148,4 +150,4 @@ add_avm_pack_file(_AVMPath, _Options) ->
 %%-----------------------------------------------------------------------------
 -spec close_avm_pack(Name :: atom(), Options :: []) -> ok | error.
 close_avm_pack(_Name, _Options) ->
-    throw(nif_error).
+    erlang:nif_error(undefined).

libs/eavmlib/src/console.erl

@@ -72,7 +72,7 @@ flush(Console) ->
 %%-----------------------------------------------------------------------------
 -spec print(string()) -> ok | {error, term()}.
 print(_String) ->
-    throw(nif_error).
+    erlang:nif_error(undefined).
 
 %% Internal operations