Merge pull request #1810 from pguyot/w34/flappy-timeout

Add timeouts to debug flappiness and reduce CI time

These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).

SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later

Author: bettio

tests/libs/estdlib/test_gen_tcp.erl

@@ -195,6 +195,8 @@ test_listen_connect_parameters(
     receive
         {ServerPid, ready} ->
             ok
+    after 10000 ->
+        error({timeout, ?MODULE, ?LINE})
     end,
 
     {ok, Socket} = gen_tcp:connect(

tests/libs/estdlib/test_gen_udp.erl

@@ -74,25 +74,36 @@ test_send_receive(SpawnControllingProcess, IsActive, Mode, BackendOption) ->
             gen_udp:controlling_process(Socket, Pid),
             receive
                 ready -> ok
+            after 10000 ->
+                error({timeout, ?MODULE, ?LINE})
             end;
         false ->
             ok
     end,
 
     NumToSend = 10,
-    Sender = erlang:spawn(?MODULE, start_sender, [Socket, Port, make_messages(NumToSend)]),
+    {Sender, SenderMonitor} = erlang:spawn_opt(
+        ?MODULE, start_sender, [Socket, Port, make_messages(NumToSend)], [monitor]
+    ),
 
     NumReceived =
         case SpawnControllingProcess of
             true ->
                 receive
                     {done, Received} ->
                         Received
+                after 10000 ->
+                    error({timeout, ?MODULE, ?LINE})
                 end;
             false ->
                 F()
         end,
     Sender ! stop,
+    receive
+        {'DOWN', SenderMonitor, process, Sender, normal} -> ok
+    after 10000 ->
+        error({timeout, ?MODULE, ?LINE})
+    end,
 
     ?ASSERT_TRUE((0 < NumReceived) and (NumReceived =< NumToSend)),
     %% NB. Might be closed if controlling process terminates