Fix duplicate linked objects warnings

Signed-off-by: Paul Guyot <[email protected]>

Author: pguyot

src/libAtomVM/CMakeLists.txt

@@ -306,10 +306,6 @@ endif()
 target_include_directories(libAtomVM PUBLIC ${CMAKE_CURRENT_BINARY_DIR})
 configure_file(${CMAKE_CURRENT_SOURCE_DIR}/version.h.in ${CMAKE_CURRENT_BINARY_DIR}/avm_version.h)
 
-if (NOT ${CMAKE_SYSTEM_NAME} STREQUAL "Generic")
-    target_link_libraries(libAtomVM PUBLIC libAtomVM${CMAKE_SYSTEM_NAME}-${CMAKE_SYSTEM_PROCESSOR})
-endif()
-
 add_dependencies(libAtomVM generated generated-nifs-hash)
 
 if (COVERAGE)

src/platforms/generic_unix/CMakeLists.txt

@@ -44,13 +44,11 @@ add_subdirectory(lib)
 target_include_directories(AtomVM PUBLIC lib/)
 
 add_subdirectory(../../libAtomVM libAtomVM)
-target_link_libraries(AtomVM PRIVATE libAtomVM)
-
 set(
     PLATFORM_LIB_SUFFIX
     ${CMAKE_SYSTEM_NAME}-${CMAKE_SYSTEM_PROCESSOR}
 )
-target_link_libraries(AtomVM PRIVATE libAtomVM${PLATFORM_LIB_SUFFIX})
+target_link_libraries(AtomVM PRIVATE libAtomVM libAtomVM${PLATFORM_LIB_SUFFIX})
 
 if(AVM_DISABLE_JIT)
 set(precompiled_suffix)

src/platforms/generic_unix/lib/CMakeLists.txt

@@ -69,7 +69,11 @@ define_if_function_exists(libAtomVM${PLATFORM_LIB_SUFFIX} signal "signal.h" PRIV
 define_if_function_exists(libAtomVM${PLATFORM_LIB_SUFFIX} getservbyname "netdb.h" PRIVATE HAVE_SERVBYNAME)
 define_if_function_exists(libAtomVM${PLATFORM_LIB_SUFFIX} gethostname "unistd.h" PRIVATE HAVE_GETHOSTNAME)
 
-target_link_libraries(libAtomVM${PLATFORM_LIB_SUFFIX} PUBLIC libAtomVM)
+# Get include directories and compile definitions from libAtomVM without linking
+target_include_directories(libAtomVM${PLATFORM_LIB_SUFFIX} PRIVATE
+    $<TARGET_PROPERTY:libAtomVM,INTERFACE_INCLUDE_DIRECTORIES>)
+target_compile_definitions(libAtomVM${PLATFORM_LIB_SUFFIX} PRIVATE
+    $<TARGET_PROPERTY:libAtomVM,INTERFACE_COMPILE_DEFINITIONS>)
 include_directories(${CMAKE_SOURCE_DIR}/src/platforms/generic_unix/lib)
 
 include(MbedTLS)

tests/CMakeLists.txt

@@ -58,15 +58,6 @@ if(${CMAKE_SYSTEM_NAME} STREQUAL "Linux")
     endif()
 endif()
 
-include(MbedTLS)
-if (MbedTLS_FOUND)
-    target_link_libraries(test-erlang PRIVATE MbedTLS::mbedtls)
-    target_link_libraries(test-enif PRIVATE MbedTLS::mbedtls)
-    target_link_libraries(test-heap PRIVATE MbedTLS::mbedtls)
-    target_link_libraries(test-mailbox PRIVATE MbedTLS::mbedtls)
-    target_link_libraries(test-structs PRIVATE MbedTLS::mbedtls)
-endif()
-
 set(
     PLATFORM_LIB_SUFFIX
     ${CMAKE_SYSTEM_NAME}-${CMAKE_SYSTEM_PROCESSOR}

tools/packbeam/CMakeLists.txt

@@ -49,10 +49,8 @@ set(
     PLATFORM_LIB_SUFFIX
     ${CMAKE_SYSTEM_NAME}-${CMAKE_SYSTEM_PROCESSOR}
 )
-target_link_libraries(PackBEAM PRIVATE libAtomVM${PLATFORM_LIB_SUFFIX})
-
+target_link_libraries(PackBEAM PRIVATE libAtomVM libAtomVM${PLATFORM_LIB_SUFFIX})
 target_include_directories(PackBEAM PUBLIC ../../src/libAtomVM)
-target_link_libraries(PackBEAM PRIVATE libAtomVM)
 
 if (COVERAGE)
     include(CodeCoverage)