Merge pull request #1846 from pguyot/w39/use-clang-pedantic

Use -Wpendantic with Clang, fix AVMCCS-L002 issues

These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).

SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later

Author: bettio

C_CODING_STYLE.md

@@ -141,12 +141,12 @@ void f(bool reverse) {
 - **Function spacing**: Separate function definitions with exactly one empty line [AVMCCS-F008]
 
   ```c
-  void first_function()
+  void first_function(void)
   {
       // implementation
   }
 
-  void second_function()
+  void second_function(void)
   {
       // implementation
   }

src/libAtomVM/CMakeLists.txt

@@ -131,7 +131,7 @@ target_compile_features(libAtomVM PUBLIC c_std_11)
 if (CMAKE_C_COMPILER_ID STREQUAL "GNU")
     target_compile_options(libAtomVM PUBLIC -Wall ${MAYBE_PEDANTIC_FLAG} ${MAYBE_WERROR_FLAG} -Wextra -ggdb -Werror=incompatible-pointer-types)
 elseif (CMAKE_C_COMPILER_ID MATCHES "Clang")
-    target_compile_options(libAtomVM PUBLIC -Wall --extra-warnings -Werror=incompatible-pointer-types ${MAYBE_WERROR_FLAG})
+    target_compile_options(libAtomVM PUBLIC -Wall ${MAYBE_PEDANTIC_FLAG} -Wno-gnu-zero-variadic-macro-arguments --extra-warnings -Werror=incompatible-pointer-types ${MAYBE_WERROR_FLAG})
 endif()
 
 if (ENABLE_REALLOC_GC)

src/libAtomVM/atom_table.c

@@ -80,7 +80,7 @@ struct AtomTable
 
 static struct HNodeGroup *new_node_group(struct AtomTable *table, int len);
 
-struct AtomTable *atom_table_new()
+struct AtomTable *atom_table_new(void)
 {
     struct AtomTable *htable = malloc(sizeof(struct AtomTable));
     if (IS_NULL_PTR(htable)) {

src/libAtomVM/atom_table.h

@@ -55,7 +55,7 @@ enum AtomTableEnsureAtomResult
 
 typedef const void *atom_ref_t;
 
-struct AtomTable *atom_table_new();
+struct AtomTable *atom_table_new(void);
 void atom_table_destroy(struct AtomTable *table);
 
 size_t atom_table_count(struct AtomTable *table);

src/libAtomVM/context.c

@@ -91,7 +91,11 @@ Context *context_new(GlobalContext *glb)
     ctx->native_handler = NULL;
 
     ctx->saved_module = NULL;
+#ifndef AVM_NO_EMU
     ctx->saved_ip = NULL;
+#else
+    ctx->saved_function_ptr = NULL;
+#endif
     ctx->restore_trap_handler = NULL;
 
     ctx->leader = 0;
@@ -458,13 +462,18 @@ void context_process_monitor_down_signal(Context *ctx, struct TermSignal *signal
 void context_process_code_server_resume_signal(Context *ctx)
 {
 #ifndef AVM_NO_JIT
-    uint32_t label = (uint32_t) (uintptr_t) ctx->saved_ip;
+    // jit_trap_and_load stores the label in saved_function_ptr
+    uint32_t label = (uint32_t) (uintptr_t) ctx->saved_function_ptr;
     Module *module = ctx->saved_module;
+#ifndef AVM_NO_EMU
     if (module->native_code) {
-        ctx->saved_ip = (ModuleNativeEntryPoint) module_get_native_entry_point(module, label);
+        ctx->saved_function_ptr = module_get_native_entry_point(module, label);
     } else {
         ctx->saved_ip = module->labels[label];
     }
+#else
+    ctx->saved_function_ptr = module_get_native_entry_point(module, label);
+#endif
     // Fix CP to OP_INT_CALL_END
     if (ctx->cp == module_address(module->module_index, 0)) {
         ctx->cp = module_address(module->module_index, module->end_instruction_ii);

src/libAtomVM/context.h

@@ -29,6 +29,7 @@
 #define _CONTEXT_H_
 
 #include "globalcontext.h"
+#include "jit.h"
 #include "list.h"
 #include "mailbox.h"
 #include "smp.h"
@@ -114,7 +115,15 @@ struct Context
 
     // saved state when scheduled out
     Module *saved_module;
-    const void *saved_ip;
+    union
+    {
+#ifndef AVM_NO_EMU
+        const void *saved_ip;
+#endif
+#ifndef AVM_NO_JIT
+        ModuleNativeEntryPoint saved_function_ptr;
+#endif
+    };
     // pointer to a trap or wait timeout handler
     void *restore_trap_handler;
 

src/libAtomVM/ets_hashtable.c

@@ -40,7 +40,7 @@ struct HNode
 
 static uint32_t hash_term(term t, GlobalContext *global);
 
-struct EtsHashTable *ets_hashtable_new()
+struct EtsHashTable *ets_hashtable_new(void)
 {
     struct EtsHashTable *htable = malloc(sizeof(struct EtsHashTable));
     if (IS_NULL_PTR(htable)) {

src/libAtomVM/ets_hashtable.h

@@ -49,7 +49,7 @@ typedef enum EtsHashtableStatus
     EtsHashtableOutOfMemory
 } EtsHashtableStatus;
 
-struct EtsHashTable *ets_hashtable_new();
+struct EtsHashTable *ets_hashtable_new(void);
 void ets_hashtable_destroy(struct EtsHashTable *hash_table, GlobalContext *global);
 
 EtsHashtableStatus ets_hashtable_insert(struct EtsHashTable *hash_table, struct HNode *new_node, EtsHashtableOptions opts, GlobalContext *global);

src/libAtomVM/globalcontext.c

@@ -59,7 +59,7 @@ struct RegisteredProcess
     term local_pid_or_port;
 };
 
-GlobalContext *globalcontext_new()
+GlobalContext *globalcontext_new(void)
 {
     GlobalContext *glb = malloc(sizeof(GlobalContext));
     if (IS_NULL_PTR(glb)) {
@@ -238,7 +238,7 @@ COLD_FUNC void globalcontext_destroy(GlobalContext *glb)
         struct RefcBinary *refc = GET_LIST_ENTRY(item, struct RefcBinary, head);
 #ifndef NDEBUG
         if (refc->resource_type) {
-            fprintf(stderr, "Warning, dangling resource of type %s, ref_count = %d, data = %p\n", refc->resource_type->name, (int) refc->ref_count, refc->data);
+            fprintf(stderr, "Warning, dangling resource of type %s, ref_count = %d, data = %p\n", refc->resource_type->name, (int) refc->ref_count, (void *) refc->data);
         } else {
             fprintf(stderr, "Warning, dangling refc binary, ref_count = %d\n", (int) refc->ref_count);
         }

src/libAtomVM/globalcontext.h

@@ -192,7 +192,7 @@ enum SendMessageResult
  * @details Allocates a new GlobalContext struct and initialize it, the newly created global context is a new AtomVM instance.
  * @returns A newly created GlobalContext.
  */
-GlobalContext *globalcontext_new();
+GlobalContext *globalcontext_new(void);
 
 /**
  * @brief Destoys an existing GlobalContext