Allow timeouts up to 64 bits (OTP-25 behavior)

Signed-off-by: Fred Dushin <[email protected]>

Author: fadushin

src/libAtomVM/opcodesswitch.h

@@ -2120,15 +2120,16 @@ static bool maybe_call_native(Context *ctx, AtomString module_name, AtomString f
                 DECODE_COMPACT_TERM(timeout, code, i, next_off)
 
                 #ifdef IMPL_EXECUTE_LOOP
+                    avm_int64_t t = 0;
                     if (term_is_any_integer(timeout)) {
-                        avm_int64_t t = term_maybe_unbox_int64(timeout);
-                        if (t < 0 || t > 4294967295L) {
+                        t = term_maybe_unbox_int64(timeout);
+                        if (UNLIKELY(t < 0)) {
                             RAISE_ERROR(TIMEOUT_VALUE_ATOM);
                         }
                     } else if (UNLIKELY(timeout != INFINITY_ATOM)) {
                         RAISE_ERROR(TIMEOUT_VALUE_ATOM);
                     }
-                    TRACE("wait_timeout/2, label: %i, timeout: %li\n", label, (long int) term_to_int32(timeout));
+                    TRACE("wait_timeout/2, label: %i, timeout: %li\n", label, (long int) t);
 
                     NEXT_INSTRUCTION(next_off);
                     //TODO: it looks like x[0] might be used instead of jump_to_on_restore
@@ -2139,7 +2140,7 @@ static bool maybe_call_native(Context *ctx, AtomString module_name, AtomString f
                     int needs_to_wait = 0;
                     if ((ctx->flags & (WaitingTimeout | WaitingTimeoutExpired)) == 0) {
                         if (timeout != INFINITY_ATOM) {
-                            scheduler_set_timeout(ctx, term_to_int32(timeout));
+                            scheduler_set_timeout(ctx, t);
                         }
                         needs_to_wait = 1;
                     } else if ((ctx->flags & WaitingTimeout) != 0) {

src/libAtomVM/scheduler.c

@@ -139,7 +139,7 @@ static void scheduler_timeout_callback(struct TimerWheelItem *it)
     scheduler_make_ready(ctx->global, ctx);
 }
 
-void scheduler_set_timeout(Context *ctx, uint32_t timeout)
+void scheduler_set_timeout(Context *ctx, avm_int64_t timeout)
 {
     GlobalContext *glb = ctx->global;
 

src/libAtomVM/scheduler.h

@@ -102,7 +102,7 @@ Context *scheduler_next(GlobalContext *global, Context *c);
  * @param ctx the context that will be put on sleep
  * @param timeout amount of time to be waited in milliseconds.
  */
-void scheduler_set_timeout(Context *ctx, uint32_t timeout);
+void scheduler_set_timeout(Context *ctx, avm_int64_t timeout);
 
 void scheduler_cancel_timeout(Context *ctx);
 

src/libAtomVM/timer_wheel.h

@@ -29,6 +29,7 @@ extern "C" {
 #include <stdint.h>
 
 #include "list.h"
+#include "term_typedef.h"
 
 struct TimerWheelItem;
 typedef void(timer_wheel_callback_t)(struct TimerWheelItem *);
@@ -84,7 +85,7 @@ static inline void timer_wheel_item_init(struct TimerWheelItem *it, timer_wheel_
     it->callback = cb;
 }
 
-static inline uint64_t timer_wheel_expiry_to_monotonic(const struct TimerWheel *tw, uint32_t expiry)
+static inline uint64_t timer_wheel_expiry_to_monotonic(const struct TimerWheel *tw, avm_int64_t expiry)
 {
     return tw->monotonic_time + expiry;
 }

tests/libs/estdlib/test_timer.erl

@@ -67,7 +67,6 @@ timer_loop(I) ->
 
 test_timer_badargs() ->
     {'EXIT', {timeout_value, _}} = (catch timer:sleep(-1)),
-    {'EXIT', {timeout_value, _}} = (catch timer:sleep(4294967295 + 1)),
     {'EXIT', {timeout_value, _}} = (catch timer:sleep(not_infinity)),
     ok.