WIP: Error handling rework #1959
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RAISE()/RAISE_ERROR() is more maintainable than directly writing to registers. Signed-off-by: Davide Bettio <[email protected]>
bettio
force-pushed
the
error-handling-rework
branch
2 times, most recently
from
c1e0a45 to
85dce1e
Compare
Just use the ones defined in nifs.h. Signed-off-by: Davide Bettio <[email protected]>
bettio
force-pushed
the
error-handling-rework
branch
from
85dce1e to
c8e8d05
Compare
…fields Store exception information in context fields: - exception_class (was `x[0]` register) - exception_reason (was `x[1]` register) - exception_stacktrace (was `x[2]` register). This avoids overwriting function arguments when raising an error, allowing better diagnostic, also this should allow the fix of atomvm#1951 and proposes an alternative approach to atomvm#1804. Also, simplify stacktrace_build(): it requires just Context * parameter. Signed-off-by: Davide Bettio <[email protected]>
bettio
force-pushed
the
error-handling-rework
branch
from
c8e8d05 to
e8830d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also #1951
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later