Fix: deprecated function usage (globalcontext_insert_atom) #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UncleGrumpy
suggested changes
Nov 4, 2025
Contributor
UncleGrumpy
left a comment
UncleGrumpy
left a comment
There was a problem hiding this comment.
I think ideally we want to replace the esp32 specific port with a platform agnostic pure Erlang implementation, but for the meantime it would be good to fix this.
globalcontext_insert_atom is no longer on main, and thus unable to compile. Signed-off-by: Peter M <[email protected]>
petermm
force-pushed
the
fix-globalcontext_insert_atom
branch
from
119c7ba to
aae2bbb
Compare
Contributor
|
It’s a easy thing to overlook, there are a lot of places in the AtomVM code base that atoms are not checked for safety that will need to be fixed, but I think we are still waiting for a “safe” API… or fixing globalcontext_make_atom itself to be safe. I don’t think @bettio has made a decision about that yet. |
UncleGrumpy
approved these changes
Nov 4, 2025
Contributor
UncleGrumpy
left a comment
UncleGrumpy
left a comment
There was a problem hiding this comment.
Looks good now. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
globalcontext_insert_atom is no longer on main, and thus unable to compile.
Minimal change - otherwise untested.