esp32_flash: fix crash when -b/--baud is given

The legacy (non-namespaced) esp32_flash task typed baud as a string
in its option spec while the atomvm-namespaced provider it delegates
to types it as an integer; any explicit -b through the legacy task
reached do_flash as a string and crashed integer_to_list/1 with
badarg. Type the legacy option as integer, and also normalize baud
in get_opts so string values from rebar.config keep working.

Signed-off-by: Paul Guyot <pguyot@kallisys.net>

Author: pguyot

src/atomvm_esp32_flash_provider.erl

@@ -107,10 +107,14 @@ get_opts(State) ->
     {ParsedArgs, _} = rebar_state:command_parsed_args(State),
     RebarOpts = atomvm_rebar3_plugin:get_atomvm_rebar_provider_config(State, ?PROVIDER),
     ParsedOpts = atomvm_rebar3_plugin:proplist_to_map(ParsedArgs),
-    maps:merge(
+    Opts = maps:merge(
         env_opts(),
         maps:merge(RebarOpts, ParsedOpts)
-    ).
+    ),
+    % baud may arrive as a string from rebar.config or from the legacy
+    % (non-namespaced) esp32_flash task, whose option spec used to type
+    % it as a string; do_flash needs an integer.
+    Opts#{baud := maybe_convert_string(maps:get(baud, Opts))}.
 
 %% @private
 env_opts() ->

src/legacy_esp32_flash_provider.erl

@@ -31,7 +31,7 @@
     {esptool, $e, "esptool", string, "Path to esptool.py"},
     {chip, $c, "chip", string, "ESP chip (default auto)"},
     {port, $p, "port", string, "Device port (default /dev/ttyUSB0)"},
-    {baud, $b, "baud", string, "Baud rate (default 115200)"},
+    {baud, $b, "baud", integer, "Baud rate (default 115200)"},
     {offset, $o, "offset", string, "Offset (default 0x210000)"}
 ]).