feat: remove location permission handling

Author: atoui-zahreddine

example/src/App.tsx

@@ -1,13 +1,48 @@
-import { View, StyleSheet, StatusBar } from 'react-native';
+import {
+  View,
+  StyleSheet,
+  StatusBar,
+  PermissionsAndroid,
+  Platform,
+} from 'react-native';
 
-import { useEffect, useState } from 'react';
+import { useEffect, useRef, useState } from 'react';
 import {
   MapboxTurnByTurnNavigationView,
   type MapboxTurnByTurnNavigation,
 } from 'react-native-mapbox-turn-by-turn-navigation';
 
 export default function App() {
   const [hybridRef, setHybridRef] = useState<MapboxTurnByTurnNavigation>();
+  const isMountedRef = useRef<boolean>(true);
+  const [ready, setReady] = useState(false);
+
+  const checkPermissions = async () => {
+    try {
+      const granted = await PermissionsAndroid.request(
+        PermissionsAndroid.PERMISSIONS.ACCESS_FINE_LOCATION
+      );
+      if (granted !== PermissionsAndroid.RESULTS.GRANTED) {
+        console.warn('Location permission not granted');
+        return;
+      }
+      if (isMountedRef.current) setReady(true);
+    } catch (error) {
+      console.error('Error checking permissions:', error);
+    }
+  };
+
+  useEffect(() => {
+    isMountedRef.current = true;
+    if (Platform.OS === 'android') {
+      checkPermissions();
+    } else {
+      setReady(true); // Assume permissions are granted on iOS
+    }
+    return () => {
+      isMountedRef.current = false;
+    };
+  }, []);
 
   useEffect(() => {
     let unsubscribeFromListeners: (() => void)[] = [];
@@ -56,6 +91,10 @@ export default function App() {
     };
   }, [hybridRef]);
 
+  if (!ready) {
+    return <View style={styles.container} />;
+  }
+
   return (
     <>
       <StatusBar barStyle="dark-content" />

src/index.tsx

@@ -1,3 +1,5 @@
+import type { ComponentProps } from 'react';
+
 const MapboxTurnByTurnNavigationConfig = require('../nitrogen/generated/shared/json/MapboxTurnByTurnNavigationConfig.json');
 import type {
   MapboxTurnByTurnNavigationMethods,
@@ -6,62 +8,17 @@ import type {
 
 export * from './MapboxTurnByTurnNavigation.nitro';
 
-import { type ComponentProps, useEffect, useRef, useState } from 'react';
-import {
-  PermissionsAndroid,
-  Platform,
-  type StyleProp,
-  StyleSheet,
-  View,
-  type ViewStyle,
-} from 'react-native';
+import { StyleSheet, View } from 'react-native';
 import { getHostComponent } from 'react-native-nitro-modules';
 
 export const NativeView = getHostComponent<
   MapboxTurnByTurnNavigationProps,
   MapboxTurnByTurnNavigationMethods
 >('MapboxTurnByTurnNavigation', () => MapboxTurnByTurnNavigationConfig);
 
-type NativeViewProps = ComponentProps<typeof NativeView>;
-interface MapboxTurnByTurnNavigationView extends NativeViewProps {
-  style?: StyleProp<ViewStyle>;
-}
 export const MapboxTurnByTurnNavigationView = (
-  props: MapboxTurnByTurnNavigationView
+  props: ComponentProps<typeof NativeView>
 ) => {
-  const isMountedRef = useRef<boolean>(true);
-  const [ready, setReady] = useState(false);
-
-  const checkPermissions = async () => {
-    try {
-      const granted = await PermissionsAndroid.request(
-        PermissionsAndroid.PERMISSIONS.ACCESS_FINE_LOCATION
-      );
-      if (granted !== PermissionsAndroid.RESULTS.GRANTED) {
-        console.warn('Location permission not granted');
-        return;
-      }
-      if (isMountedRef.current) setReady(true);
-    } catch (error) {
-      console.error('Error checking permissions:', error);
-    }
-  };
-
-  useEffect(() => {
-    isMountedRef.current = true;
-    if (Platform.OS === 'android') {
-      checkPermissions();
-    } else {
-      setReady(true); // Assume permissions are granted on iOS
-    }
-    return () => {
-      isMountedRef.current = false;
-    };
-  }, []);
-
-  if (!ready) {
-    return <View style={styles.container} />;
-  }
   return (
     <View style={[styles.container, props.style]}>
       <NativeView {...props} style={styles.container} />