SAMD51P - TC Clock Enabling Procedure Incomplete

[fko-kuptec]

I was trying to get a manually configured TC (timer counter) working, however it just wouldn't want to start. Today, I found out that the GenericClockController::tcx_tcy() methods are not sufficient to enable the clocks for a TC instance. Additionally, the corresponding tcx_ bit in the APB mask of the MCLK must be set. Since the GenericClockController consumes MCLK at construction and does not seem to expose direct access to it, I have to set this bit before creating the GenericClockController instance. Now, the timer works.

Maybe I am mistaken, but I would expect these mask bits to be automatically set by the tcx_tcy() methods. Is this intended behaviour?

I don't know, whether this issue only affects the SAMD51P or the other targets as well.

Thank you for your work! 😊

[fko-kuptec]

I am not sure, whether the API was changed or I just misread something. But the GenericClockController does not consume the MCLK at construction. Therefore, it is possible to set the required MCLK bits after creating the GenericClockController.

One question still remains, however, whether it would make for a better API if the GenericClockController::tcx_tcy() methods would automatically set the corresponding MCLK bits.