Skip to content

Commit 2c380b2

Browse files
committed
Fix wrong bounding boxes in tests
1 parent 139b62a commit 2c380b2

File tree

1 file changed

+16
-13
lines changed

1 file changed

+16
-13
lines changed

unittests/general.tests.cpp

Lines changed: 16 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -309,9 +309,9 @@ namespace GeneralTest
309309
using BoundingBoxXD = BoundingBoxND<N>;
310310
auto constexpr vBox = array
311311
{
312-
BoundingBoxXD{ 0.0, 4.0 },
313-
BoundingBoxXD{ 0.0, 2.0 }, BoundingBoxXD{ 2.0, 4.0 },
314-
BoundingBoxXD{ 0.0, 1.0 }, BoundingBoxXD{ 1.0, 2.0 }, BoundingBoxXD{ 2.0, 3.0 }, BoundingBoxXD{ 3.0, 4.0 }
312+
BoundingBoxXD{ { 0.0} , {4.0} },
313+
BoundingBoxXD{ { 0.0} , {2.0} }, BoundingBoxXD{ { 2.0 }, { 4.0 } },
314+
BoundingBoxXD{ { 0.0} , {1.0} }, BoundingBoxXD{ { 1.0 }, { 2.0 } }, BoundingBoxXD{ { 2.0 }, { 3.0 } }, BoundingBoxXD{ { 3.0 }, { 4.0 } }
315315
};
316316

317317
auto const treeExpected = TreeBoxND<N>(vBox, 3);
@@ -2116,7 +2116,7 @@ namespace Tree2DTest
21162116
BoundingBox3D{ { 0.0, 0.0, 0.0 }, { 1.0, 1.0, 0.0 } },
21172117
BoundingBox3D{ { 1.0, 1.0, -1.0 }, { 2.0, 2.0, 0.0 } },
21182118
BoundingBox3D{ { 2.0, 2.0, -1.0 }, { 3.0, 3.0, -0.2 } },
2119-
BoundingBox3D{ { 3.0, 3.0, 1.0 }, { 4.0, 4.0, 0.2 } },
2119+
BoundingBox3D{ { 3.0, 3.0, 1.0 }, { 4.0, 4.0, 1.2 } },
21202120
BoundingBox3D{ { 1.2, 1.2, -1.0 }, { 2.8, 2.8, 1.0 } }
21212121
};
21222122

@@ -2134,7 +2134,7 @@ namespace Tree2DTest
21342134
BoundingBox3D{ { 0.0, 0.0, 0.0 }, { 1.0, 1.0, 0.0 } },
21352135
BoundingBox3D{ { 1.0, 1.0, -1.0 }, { 2.0, 2.0, 0.0 } },
21362136
BoundingBox3D{ { 2.0, 2.0, -1.0 }, { 3.0, 3.0, -0.2 } },
2137-
BoundingBox3D{ { 3.0, 3.0, 1.0 }, { 4.0, 4.0, 0.2 } },
2137+
BoundingBox3D{ { 3.0, 3.0, 0.8 }, { 4.0, 4.0, 0.9 } },
21382138
BoundingBox3D{ { 1.2, 1.2, -1.0 }, { 2.8, 2.8, 1.1 } }
21392139
};
21402140

@@ -2151,7 +2151,7 @@ namespace Tree2DTest
21512151
BoundingBox3D{ { 0.0, 0.0, 0.0 }, { 1.0, 1.0, 0.0 } },
21522152
BoundingBox3D{ { 1.0, 1.0, -1.0 }, { 2.0, 2.0, 0.0 } },
21532153
BoundingBox3D{ { 2.0, 2.0, -1.0 }, { 3.0, 3.0, -0.2 } },
2154-
BoundingBox3D{ { 3.0, 3.0, 1.0 }, { 4.0, 4.0, 0.2 } },
2154+
BoundingBox3D{ { 3.0, 3.0, 1.0 }, { 4.0, 4.0, 1.2 } },
21552155
BoundingBox3D{ { 1.2, 1.2, -1.1 }, { 2.8, 2.8, 1.1 } }
21562156
};
21572157

@@ -2169,7 +2169,7 @@ namespace Tree2DTest
21692169
BoundingBox3D{ { 0.0, 0.0, 0.0 }, { 1.0, 1.0, 0.0 } },
21702170
BoundingBox3D{ { 1.0, 1.0, -1.0 }, { 2.0, 2.0, 0.0 } },
21712171
BoundingBox3D{ { 2.0, 2.0, -1.0 }, { 3.0, 3.0, -0.2 } },
2172-
BoundingBox3D{ { 3.0, 3.0, 1.0 }, { 4.0, 4.0, 0.2 } },
2172+
BoundingBox3D{ { 3.0, 3.0, 1.0 }, { 4.0, 4.0, 1.2 } },
21732173
BoundingBox3D{ { 1.2, 1.2, -1.1 }, { 2.8, 2.8, 1.1 } }
21742174
};
21752175

@@ -2186,7 +2186,7 @@ namespace Tree2DTest
21862186
BoundingBox3D{ { 0.0, 0.0, 0.0 }, { 1.0, 1.0, 0.0 } },
21872187
BoundingBox3D{ { 1.0, 1.0, -1.0 }, { 2.0, 2.0, 0.0 } },
21882188
BoundingBox3D{ { 2.0, 2.0, -1.0 }, { 3.0, 3.0, -0.2 } },
2189-
BoundingBox3D{ { 3.0, 3.0, 1.0 }, { 4.0, 4.0, 0.2 } },
2189+
BoundingBox3D{ { 3.0, 3.0, 1.0 }, { 4.0, 4.0, 1.2 } },
21902190
BoundingBox3D{ { 1.2, 1.2, -1.1 }, { 2.8, 2.8, 1.1 } }
21912191
};
21922192

@@ -2203,7 +2203,7 @@ namespace Tree2DTest
22032203
BoundingBox3D{ { 0.0, 0.0, 0.0 }, { 1.0, 1.0, 0.0 } },
22042204
BoundingBox3D{ { 1.0, 1.0, -1.0 }, { 2.0, 2.0, 0.0 } },
22052205
BoundingBox3D{ { 2.0, 2.0, -1.0 }, { 3.0, 3.0, -0.2 } },
2206-
BoundingBox3D{ { 3.0, 3.0, 1.0 }, { 4.0, 4.0, 0.2 } },
2206+
BoundingBox3D{ { 3.0, 3.0, 1.0 }, { 4.0, 4.0, 1.2 } },
22072207
BoundingBox3D{ { 1.2, 1.2, -1.1 }, { 2.8, 2.8, 1.1 } }
22082208
};
22092209

@@ -2219,7 +2219,7 @@ namespace Tree2DTest
22192219
BoundingBox3D{ { 0.0, 0.0, 0.0 }, { 1.0, 1.0, 0.0 } },
22202220
BoundingBox3D{ { 1.0, 1.0, -1.0 }, { 2.0, 2.0, 0.0 } },
22212221
BoundingBox3D{ { 2.0, 2.0, -1.0 }, { 3.0, 3.0, -0.2 } },
2222-
BoundingBox3D{ { 3.0, 3.0, 1.0 }, { 4.0, 4.0, 0.2 } },
2222+
BoundingBox3D{ { 3.0, 3.0, 1.0 }, { 4.0, 4.0, 1.2 } },
22232223
BoundingBox3D{ { 1.2, 1.2, -1.1 }, { 2.8, 2.8, 1.1 } }
22242224
};
22252225

@@ -2466,7 +2466,7 @@ namespace Tree3DTest
24662466
// This gives a tree with 9 nodes.
24672467
std::vector<BoundingBox3D> boxes = {
24682468
{{ -2.0, -2.0, -2.0 }, { -1.0, -1.0, +2.0 }}, // split to 8 and 12
2469-
{{ +2.0, +2.0, +2.0 }, { +4.0, +1.0, +1.0 }}, // 15
2469+
{{ +1.0, +1.0, +1.0 }, { +4.0, +3.1, +3.4 }}, // 15
24702470
{{ +2.0, +2.0, +2.0 }, { +3.1, +3.1, +3.1 }}, // 127
24712471
};
24722472
auto boxNo = boxes.size();
@@ -2480,8 +2480,11 @@ namespace Tree3DTest
24802480
},
24812481
2);
24822482

2483-
Assert::AreEqual<OctreeBox::MortonNodeID>(tree.GetNodeIDByEntity(0), 8);
2484-
Assert::AreEqual<OctreeBox::MortonNodeID>(tree.GetNodeIDByEntity(2), 127);
2483+
auto const nodeBy0 = tree.GetNodeIDByEntity(0);
2484+
Assert::IsTrue(nodeBy0 == 8 || nodeBy0 == 12);
2485+
auto const nodeBy2 = tree.GetNodeIDByEntity(2);
2486+
Assert::AreEqual<OctreeBox::MortonNodeID>(nodeBy2, 127);
2487+
24852488
Assert::AreEqual<OctreeBox::MortonNodeID>(tree.GetNodeIDByEntity(1), 15);
24862489

24872490
tree.UpdateIndexes({});

0 commit comments

Comments
 (0)