🐛 fix(external-tests): stabilize notifier webhook flow

Make global test patching robust for isolated external runs and add missing mock Horizon ledger-transactions endpoint so notifier webhook delivery completes reliably in CI.

Author: attid

bot/tests/conftest.py

@@ -862,7 +862,9 @@ def mock_global_data_autouse():
         "other.lang_tools.my_gettext",
         side_effect=lambda chat_id, key, param=None, **kwargs: f"text {key}",
     )
-    p2 = patch("infrastructure.utils.common_utils.get_user_id", return_value=123)
+    from infrastructure.utils import common_utils
+
+    p2 = patch.object(common_utils, "get_user_id", return_value=123)
 
     p3.start()
     p2.start()
@@ -1187,22 +1189,35 @@ async def get_ledgers(request):
         state.requests.append(
             {"endpoint": "ledgers", "method": "GET", "params": params}
         )
+        ledger_record = {
+            "id": "123456789",
+            "sequence": 12345,
+            "hash": "hash123",
+            "paging_token": "12345",
+            "closed_at": "2024-01-01T00:00:00Z",
+        }
+
+        if "text/event-stream" in request.headers.get("Accept", ""):
+            import json
+
+            response = web.StreamResponse(
+                status=200,
+                reason="OK",
+                headers={
+                    "Content-Type": "text/event-stream",
+                    "Cache-Control": "no-cache",
+                    "Connection": "keep-alive",
+                },
+            )
+            await response.prepare(request)
+            await response.write(b'event: open\ndata: "hello"\n\n')
+            await response.write(
+                f"data: {json.dumps(ledger_record)}\n\n".encode("utf-8")
+            )
+            return response
+
         # Return a simple ledger list to satisfy basic polling
-        return web.json_response(
-            {
-                "_embedded": {
-                    "records": [
-                        {
-                            "id": "123456789",
-                            "sequence": 12345,
-                            "hash": "hash123",
-                            "paging_token": "12345",
-                            "closed_at": "2024-01-01T00:00:00Z",
-                        }
-                    ]
-                }
-            }
-        )
+        return web.json_response({"_embedded": {"records": [ledger_record]}})
 
     @routes.get("/ledgers/{sequence}")
     async def get_ledger_by_seq(request):
@@ -1217,6 +1232,26 @@ async def get_ledger_by_seq(request):
             }
         )
 
+    @routes.get("/ledgers/{sequence}/transactions")
+    async def get_ledger_transactions(request):
+        """Mock transactions-by-ledger endpoint used by notifier polling."""
+        seq = request.match_info["sequence"]
+        params = dict(request.query)
+        state.requests.append(
+            {
+                "endpoint": "ledger-transactions",
+                "method": "GET",
+                "sequence": seq,
+                "params": params,
+            }
+        )
+
+        cursor = params.get("cursor", "0")
+        limit = int(params.get("limit", 10))
+        filtered = [tx for tx in state.transactions if tx["paging_token"] > cursor]
+        records = filtered[:limit]
+        return web.json_response({"_embedded": {"records": records}})
+
     @routes.get("/operations")
     async def get_operations(request):
         """Mock operations endpoint."""

bot/tests/external/test_notifier_flow.py

@@ -4,6 +4,7 @@
 from aiohttp import web
 import time
 import json
+import os
 from urllib.parse import quote
 from testcontainers.core.container import DockerContainer
 from testcontainers.core.network import Network
@@ -236,8 +237,11 @@ async def webhook_handler(request):
         )
 
         # Wait for Webhook
+        wait_timeout = float(os.getenv("NOTIFIER_WEBHOOK_TIMEOUT", "45"))
         try:
-            webhook_data = await asyncio.wait_for(webhook_queue.get(), timeout=15.0)
+            webhook_data = await asyncio.wait_for(
+                webhook_queue.get(), timeout=wait_timeout
+            )
             # Notifier service sends 'operation' type for operation events
             assert webhook_data["type"] == "operation"
             # Depending on Notifier implementation, verify content