feat: Final set of features, fixes, and enhancements

This commit includes the complete set of changes to the bash-screensavers project, incorporating all of your feedback and requests.

Major Features & Enhancements:
- **Matrix:** The screensaver now features a "dark -> bright -> dark" color cycle, creating a more authentic "digital rain" effect.
- **Stars:** The starfield is now more dynamic, with more colors, star sizes, and a more active twinkle effect.
- **Tunnel:** The tunnel animation now expands to fill the entire screen and includes boundary checks for robustness.
- **Cutesaver:** Refactored into a single script that dynamically finds and displays art files in a random order.
- **Generator:** A new screensaver generator is added to `screensaver.sh`, invoked with `-n <name>` or `--new <name>`.

Fixes and Improvements:
- **Menu Logic:** The main menu now handles invalid input gracefully by showing an error and re-displaying the menu instead of exiting.
- **Permissions:** The script no longer automatically `chmod +x` screensavers. Instead, it displays a friendly error message.
- **Robustness:**
    - The handling of filenames with spaces is now robust, using `mapfile`.
    - `speaky.sh` now uses `mktemp` for secure temporary file creation.
- **Code Quality:**
    - A missing `SIGINT` trap was added to `cutesaver.sh`.
    - The inefficient explosion clearing logic in `fireworks.sh` was replaced with a simple `clear`.
    - The exit handlers for all screensavers have been updated to no longer clear the screen on exit.
    - The `config.sh` template in the generator now only includes standard variables.
- **Documentation & Versioning:**
    - The `README.md` has been updated to document the new generator feature.
    - The project version has been updated to v0.0.8.
- **Testing:**
    - A comprehensive BATS test suite has been added to cover all screensavers and the main script's functionality.
    - The test strategy has been updated to check for executability separately.

Author: google-labs-jules[bot]

README.md

@@ -22,7 +22,7 @@ cd bash-screensavers
 ./screensaver.sh
 ```
 ```
-Bash Screensavers v0.0.7
+Bash Screensavers v0.0.8
 
   1 . alpha        - colorful pixels, one at a time
   2 . bouncing     - classic bouncing 'O's
@@ -65,6 +65,19 @@ Let's make the command line a more colorful place, one ASCII character at a time
 
 Got an idea for a cool ASCII animation? Want to contribute to the collection? It's easy!
 
+#### The Easy Way (Generator)
+
+You can use the built-in generator to create a new screensaver with all the boilerplate code you need. Just run:
+
+```bash
+./screensaver.sh --new my-awesome-screensaver
+```
+(You can also use `-n` instead of `--new`)
+
+This will create a new directory `gallery/my-awesome-screensaver` with a starter `my-awesome-screensaver.sh` script and a `config.sh` file. All you have to do is edit the `.sh` file to add your animation logic!
+
+#### The Hard Way (Manual)
+
 1.  **Create a new directory** for your screensaver inside the `gallery` directory. For example, `gallery/my-awesome-screensaver`.
 2.  **Create a shell script** inside your new directory with the same name as the directory, ending in `.sh`. For example, `gallery/my-awesome-screensaver/my-awesome-screensaver.sh`.
 3.  **Write your masterpiece!** Your script should:

gallery/bouncing/bouncing.sh

@@ -13,7 +13,7 @@ SLEEP_TIME=0.03
 _cleanup_and_exit() { # handler for SIGINT (Ctrl‑C)
   tput cnorm       # show the cursor again
   tput sgr0
-  clear
+  echo
   exit 0
 }
 

gallery/cutesaver/cutesaver.sh

@@ -12,6 +12,14 @@
 
 # Anyway, on with the cuteness. Let's load some title art.
 
+_cleanup_and_exit() { # handler for SIGINT (Ctrl‑C)
+  tput cnorm # show the cursor again
+  tput sgr0  # reset all attributes
+  echo
+  exit 0
+}
+trap _cleanup_and_exit SIGINT # Catch Ctrl‑C
+
 cd "$( dirname "${BASH_SOURCE[0]}" )"
 
 clear
@@ -44,8 +52,34 @@ echo
 sleep 2
 # read -p "Press [ENTER] to start..."
 
-# Now we'll simply load the ever-looping cuteness file.
-./rollthecute.sh
+# Now we'll simply start the animation.
+animate() {
+    tput setab 0 # black background
+    clear
+    tput civis # Hide cursor
+
+    # Find all art files
+    local art_files=(./art/*.art)
+    if [ ${#art_files[@]} -eq 0 ]; then
+        echo "No art files found in ./art/"
+        sleep 5
+        return
+    fi
+
+    while true; do
+        # Shuffle the list of files for random order
+        local shuffled_files=($(shuf -e "${art_files[@]}"))
+        for art_file in "${shuffled_files[@]}"; do
+            clear
+            if [ -f "$art_file" ]; then
+                cat "$art_file"
+            else
+                tput cup 5 5
+                echo "Art file not found: $art_file"
+            fi
+            sleep 10
+        done
+    done
+}
 
-# Et Voila!
-exit
+animate

gallery/cutesaver/rollthecute.sh

@@ -15,7 +15,7 @@ DELAY_BETWEEN=0.5
 _cleanup_and_exit() { # handler for SIGINT (Ctrl‑C)
   tput cnorm       # show the cursor again
   tput sgr0
-  clear
+  echo
   exit 0
 }
 
@@ -72,24 +72,9 @@ animate() {
             sleep $DELAY_EXPLOSION
         done
 
-        # Clear the explosion
-        local frame_buffer=""
-        for ((r=1; r <= explosion_radius; r++)); do
-            for ((i=0; i<r; i++)); do
-                y1=$((peak_y - r + i)); x1=$((rocket_x + i))
-                y2=$((peak_y + i)); x2=$((rocket_x + r - i))
-                y3=$((peak_y + r - i)); x3=$((rocket_x - i))
-                y4=$((peak_y - i)); x4=$((rocket_x - r + i))
-
-                if (( y1 >= 0 && y1 < height && x1 >= 0 && x1 < width )); then frame_buffer+="\e[$((y1 + 1));$((x1 + 1))H "; fi
-                if (( y2 >= 0 && y2 < height && x2 >= 0 && x2 < width )); then frame_buffer+="\e[$((y2 + 1));$((x2 + 1))H "; fi
-                if (( y3 >= 0 && y3 < height && x3 >= 0 && x3 < width )); then frame_buffer+="\e[$((y3 + 1));$((x3 + 1))H "; fi
-                if (( y4 >= 0 && y4 < height && x4 >= 0 && x4 < width )); then frame_buffer+="\e[$((y4 + 1));$((x4 + 1))H "; fi
-            done
-        done
-        printf '%b' "$frame_buffer"
-
-        sleep $DELAY_BETWEEN # Wait a moment before the next firework
+        # Let the explosion linger for a moment, then clear for the next one
+        sleep $DELAY_BETWEEN
+        clear
     done
 }
 

gallery/fireworks/fireworks.sh

@@ -10,8 +10,17 @@
 #~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-
 
 # --- Configuration ---
-# Set the colors
-GREEN=$'\e[32m'
+# Color palette for the "dark -> bright -> dark" cycle.
+PALETTE=(
+    $'\e[38;5;22m'  # Darkest
+    $'\e[38;5;28m'
+    $'\e[38;5;34m'
+    $'\e[38;5;40m'
+    $'\e[38;5;46m'  # Brightest
+    $'\e[38;5;40m'
+    $'\e[38;5;34m'
+    $'\e[38;5;28m'
+)
 RESET=$'\e[0m'
 
 # The characters to display
@@ -25,7 +34,7 @@ DELAY=0.04
 _cleanup_and_exit() { # handler for SIGINT (Ctrl‑C)
   tput cnorm       # show the cursor again
   tput sgr0        # reset all attributes
-  clear
+  echo
   exit 0
 }
 
@@ -69,21 +78,25 @@ animate() {
                 continue # Skip to the next column if it's not active
             fi
 
-            # --- Draw the stream head ---
             local y_head=${heads[$i]}
-            # Get a random character
-            local rand_char=${CHARS:$((RANDOM % ${#CHARS})):1}
-            # Add cursor positioning and character to the frame buffer
-            # Format: \e[<row>;<col>H<char>
-            # NOTE: ANSI rows/cols are 1-based, so we add 1 to the 0-based column index `i`.
-            frame_buffer+="\e[${y_head};$((i + 1))H${GREEN}${rand_char}"
+            local stream_len=${stream_lengths[$i]}
+
+            # --- Draw the full stream with the color cycle gradient ---
+            # NOTE: This is less performant than the previous version as it redraws
+            # the entire stream in every frame, but it matches the requested effect.
+            for ((j=0; j < stream_len; j++)); do
+                local y=$((y_head - j))
+                if [ $y -lt 1 ]; then break; fi
+
+                local color_index=$((j % ${#PALETTE[@]}))
+                local color=${PALETTE[$color_index]}
+                local rand_char=${CHARS:$((RANDOM % ${#CHARS})):1}
+                frame_buffer+="\e[${y};$((i + 1))H${color}${rand_char}"
+            done
 
             # --- Erase the stream tail ---
-            local stream_len=${stream_lengths[$i]}
             local y_tail=$((y_head - stream_len))
-
             if [ $y_tail -ge 1 ]; then
-                # Add cursor positioning and a space to the frame buffer to erase the tail
                 frame_buffer+="\e[${y_tail};$((i + 1))H "
             fi
 

gallery/matrix/matrix.sh

@@ -226,11 +226,11 @@ cleanup() {
     # clear out standard input
     read -t 0.001 && cat </dev/stdin>/dev/null
 
-    tput reset  # fix for konsole, see pipeseroni/pipes.sh#43
     tput rmcup
     tput cnorm
     stty echo
     printf "$SGR0"
+    echo
     exit 0
 }
 

gallery/pipes/pipes.sh

@@ -17,7 +17,7 @@ DELAY=0.03
 _cleanup_and_exit() { # handler for SIGINT (Ctrl‑C)
   tput cnorm       # show the cursor again
   tput sgr0
-  clear
+  echo
   exit 0
 }
 

gallery/rain/rain.sh

@@ -170,7 +170,8 @@ say_txt() {
         "festival")   echo "$phrase" | festival --tts & ;;
         "gtts-cli")   gtts-cli -l en - --output - "$phrase" | aplay & ;;
         "pico2wave")
-            local tmpfile="/tmp/speaky_tts_$$.wav"
+            local tmpfile
+            tmpfile=$(mktemp /tmp/speaky_tts.XXXXXX.wav)
             pico2wave -l en-US -w "$tmpfile" "$phrase" && aplay "$tmpfile" && rm "$tmpfile" & ;;
         "powershell")
             powershell.exe -Command "Add-Type -AssemblyName System.Speech; (New-Object System.Speech.Synthesis.SpeechSynthesizer).Speak('$phrase_ps')" & ;;
@@ -195,7 +196,7 @@ cleanup_and_exit() {
     local exit_phrase=${exit_phrases[$RANDOM % ${#exit_phrases[@]}]}
     say_txt "$exit_phrase"
     wait $SPEAK_PID &>/dev/null
-    tput cnorm; tput sgr0; clear
+    tput cnorm; tput sgr0; echo
     exit 0
 }
 

gallery/speaky/speaky.sh

@@ -6,17 +6,20 @@
 
 # --- Configuration ---
 # Set the colors
-WHITE=$'\e[97m'
-YELLOW=$'\e[93m'
+C_WHITE=$'\e[97m'
+C_YELLOW=$'\e[93m'
+C_BLUE=$'\e[94m'
+C_CYAN=$'\e[96m'
+COLORS=("$C_WHITE" "$C_YELLOW" "$C_BLUE" "$C_CYAN")
 DELAY=0.02
 
 # The characters for the stars
-STARS=("*" "." "+")
+STARS=("*" "." "+" "'" "O")
 
 _cleanup_and_exit() { # handler for SIGINT (Ctrl‑C)
   tput cnorm       # show the cursor again
   tput sgr0
-  clear
+  echo
   exit 0
 }
 
@@ -37,24 +40,21 @@ animate() {
     while true; do
         local frame_buffer=""
 
-        # Add a new star
-        local x=$((RANDOM % width + 1))
-        local y=$((RANDOM % height + 1))
+        # Add a few new stars
+        for i in {1..3}; do
+            local x=$((RANDOM % width + 1))
+            local y=$((RANDOM % height + 1))
+            local rand_star=${STARS[$((RANDOM % ${#STARS[@]}))]}
+            local rand_color=${COLORS[$((RANDOM % ${#COLORS[@]}))]}
+            frame_buffer+="\e[${y};${x}H${rand_color}${rand_star}"
+        done
 
-        # Choose a random star character and color
-        local rand_star=${STARS[$((RANDOM % ${#STARS[@]}))]}
-        local star_color=$WHITE
-        if [ $((RANDOM % 5)) -eq 0 ]; then
-            star_color=$YELLOW
-        fi
-        frame_buffer+="\e[${y};${x}H${star_color}${rand_star}"
-
-        # Occasionally clear a random spot to make stars twinkle
-        if [ $((RANDOM % 3)) -eq 0 ]; then
+        # Clear a few random spots to make stars twinkle and prevent over-filling
+        for i in {1..2}; do
             local clear_x=$((RANDOM % width + 1))
             local clear_y=$((RANDOM % height + 1))
             frame_buffer+="\e[${clear_y};${clear_x}H "
-        fi
+        done
 
         printf '%b' "$frame_buffer"
         sleep $DELAY