Merge pull request #36 from attogram/jules-attempt-005

Fix tour-the-gallery.sh and repair test suite

Author: attogram

docs/jules.md

@@ -37,4 +37,11 @@ This document provides some specific knowledge required for working on this scre
 
 ## Testing
 
-I should not attempt to run the tests in this repository. I have encountered a persistent internal error when trying to install the test dependencies. The error is `ValueError: Unexpected error: return_code: 1 stderr_contents: "cat: /app/tests/libs/bats-assert: Is a directory\n"`. This seems to be a tooling issue. If I need to run tests, I should inform the user.
+The tests for this project are written using the `bats` testing framework. Here are some key things to know about the test suite:
+
+- **Dependencies**: The tests require `bats`, `bats-support`, and `bats-assert`. These are not checked in to the repository and need to be installed. I have found that cloning them with `git` can be unreliable in this environment. It is better to download the release tarballs and extract them.
+- **Test Structure**: The main test file is `tests/tests.bats`. It is responsible for testing the main `screensaver.sh` script. There are also individual test files for each screensaver in the `tests` directory.
+- **Running Tests**: The tests should be run from the root of the repository using the command `bats tests`. This will execute all the `.bats` files in the `tests` directory.
+- **Paths**: The test scripts are written with the assumption that they are being run from the root of the repository. All paths in the test files should be relative to the root.
+- **`timeout` and Assertions**: Many of the tests use `timeout` to run the screensavers for a short period. Since the screensavers are designed to run indefinitely, `timeout` will kill them, resulting in a non-zero exit code. Therefore, the tests should use `assert_failure` to check for this expected failure, not `assert_success`.
+- **Environment Limitations**: The testing environment can be restrictive. Commands like `cd`, `pwd`, and `git restore` may not work as expected. It's important to be aware of these limitations and find workarounds when necessary.

gallery/alpha/alpha.cast

@@ -1,61 +0,0 @@
-{"version": 2, "width": 80, "height": 20, "timestamp": 1755955046, "env": {"SHELL": "/bin/bash", "TERM": "xterm-256color"}}
-[0.720489, "o", "\u001b[19;80H\u001b[38;5;62m█"]
-[1.422447, "o", "\u001b[1;76H\u001b[38;5;191m█"]
-[2.124383, "o", "\u001b[19;69H\u001b[38;5;202m█"]
-[2.826252, "o", "\u001b[10;64H\u001b[38;5;105m█"]
-[3.353391, "r", "120x29"]
-[3.390795, "r", "120x28"]
-[3.407873, "r", "120x25"]
-[3.42401, "r", "120x24"]
-[3.439409, "r", "120x22"]
-[3.456122, "r", "120x20"]
-[3.472124, "r", "120x18"]
-[3.48905, "r", "120x17"]
-[3.504977, "r", "120x16"]
-[3.528175, "o", "\u001b[16;44H\u001b[38;5;152m█"]
-[3.538063, "r", "120x15"]
-[3.783474, "r", "120x16"]
-[3.800455, "r", "120x20"]
-[3.816147, "r", "120x23"]
-[3.832598, "r", "120x26"]
-[3.849171, "r", "120x28"]
-[3.865342, "r", "120x29"]
-[3.881795, "r", "120x30"]
-[3.898557, "r", "120x31"]
-[3.931464, "r", "120x32"]
-[4.229902, "o", "\u001b[8;36H\u001b[38;5;146m█"]
-[4.931513, "o", "\u001b[9;56H\u001b[38;5;246m█"]
-[5.52677, "r", "120x31"]
-[5.560157, "r", "120x29"]
-[5.577672, "r", "120x26"]
-[5.593264, "r", "120x24"]
-[5.609105, "r", "120x22"]
-[5.625556, "r", "120x20"]
-[5.633457, "o", "\u001b[18;35H\u001b[38;5;49m█"]
-[5.642241, "r", "120x18"]
-[5.708351, "r", "120x19"]
-[5.854223, "r", "120x20"]
-[5.872922, "r", "120x21"]
-[5.889244, "r", "120x25"]
-[5.906034, "r", "120x29"]
-[5.92242, "r", "120x32"]
-[5.938984, "r", "120x34"]
-[6.187881, "r", "120x33"]
-[6.33527, "o", "\u001b[10;46H\u001b[38;5;161m█"]
-[6.42541, "r", "120x32"]
-[6.450942, "r", "120x31"]
-[6.467893, "r", "120x30"]
-[6.550745, "r", "120x29"]
-[6.616288, "r", "120x28"]
-[6.632526, "r", "120x27"]
-[6.665999, "r", "120x26"]
-[6.682584, "r", "120x24"]
-[6.699313, "r", "120x23"]
-[6.901006, "r", "120x24"]
-[7.004804, "r", "120x25"]
-[7.037282, "o", "\u001b[9;43H\u001b[38;5;156m█"]
-[7.738989, "o", "\u001b[16;11H\u001b[38;5;160m█"]
-[8.356753, "r", "112x25"]
-[8.440627, "o", "\u001b[20;50H\u001b[38;5;103m█"]
-[9.142212, "o", "\u001b[10;59H\u001b[38;5;156m█"]
-[9.844374, "o", "\u001b[12;53H\u001b[38;5;203m█"]

gallery/bouncing/bouncing.cast

@@ -1,10 +0,0 @@
-{"version": 2, "width": 80, "height": 20, "timestamp": 1755955067, "env": {"SHELL": "/bin/bash", "TERM": "xterm-256color"}}
-[0.5282, "o", "You deserve something cute to look at. A mirror would help\r\nwith that, but I'm just a lowly command line application...\r\n\r\n"]
-[1.035741, "o", "ASCII to the rescue!\r\n"]
-[1.54337, "o", "\r\nYou're about to get put into an infinite loop of cuteness.\r\n"]
-[2.050747, "o", "\r\nLeave it running for as long as you like. To exit, just press\r\nCTRL+C at any time and you'll drop back to the shell.\r\n\r\n"]
-[4.07503, "o", "\u001b[40m"]
-[4.076052, "o", "\u001b[H\u001b[2J\u001b[3J"]
-[4.077046, "o", "\u001b[?25l"]
-[4.083151, "o", "\u001b[H\u001b[2J\u001b[3J"]
-[4.087104, "o", "\r\n                                #####\r\n                  #######      #**#!!###\r\n                 #**#!!!!##   #****#!!!!#\r\n                #****###!!!#  #*****#!!!!#\r\n                #*******#!!!# #******#!!!!#\r\n                #*********#!###!*!*!*#!!!!!#        --\r\n                #!*!*!*!*!*!#!##########!!!!#      /_\r\n                ###########!##!!!!!!!!!!#!!!#     //__\r\n             ###!!!!!!!!!!!#!!!!!!!!!!!!!#!!!####///  \\\r\n   \\       ##!#!!!!!!!!!!!#!!!!!!!!!!!!!!!#!!!!!!!#\r\n   _\\    ##!!#!!!!!!!!!!!#!!!!!!!!!!!######!!!!!!!*#\r\n    \\\\  ##!!#!!!!!!!!!!!!#!!!!#######     #!!!!!!***#\r\n  ___\\\\#!!!###################*****       #...!!*****#\r\n /   \\#!!!.#       ***** #     ***        #....*******#\r\n     #*....#        ***   #              #.......*****#\r\n    #**.....##          *****          ##........!!****#\r\n    #!........##       *******#########......#...!!!!!*#\r\n   #!...........#######.*****...............#.#..!!!!**#\r\n  #*.....##.............#..#...............#...#.!!****#\r\n  #*....#.#............#....#............##......!*****#\r\n  #*.......##.......###......###........#.......!!!****#\r\n  #*.........#######......!!....########.......!!!!!***#\r\n   #!!!.................!!!!!!!!.............!!!*******#\r\n    #!!!!............!!!!!!!!!!!!!!!!!!!!!!!!!!!******#\r\n     #*******!!!!!!!!!!!!!!!!!!!!!!!!!!!!***!!!!*****#\r\n      #******!!!!!!!!!!!!!!!!!!!!!!!!!********!!****#\r\n       ##*****!!!!!!!!!!!!!!!!!!!!!#*************###\r\n         ##****!!!!!!!!!!!!!!!!!!!!!###******####\r\n           ####!!!!!!!!!!!!!!!!!!!!!!!!######!#\r\n               #!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!*#\r\n               #!!!!!!!!!!!!!!!!!!!!!!!!!!!!!***##\r\n              #!!!!!!!!!!!!!!!!!!!!!!!!!!!!!******#\r\n             #!!!!!!!!!!!!!!!!!!!!!!!!!!!!!*******#\r\n            #!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!*****#\r\n           #!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!**#\r\n          #!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!##\r\n         #!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!*##\r\n        #!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!***#\r\n        #!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!####!!!!!!****##\r\n       #!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!###****##!!!!******##\r\n       #!!!!!!!!!!!!!!!!!!!!!!!!!!!!!##**!!*****#!!!********#\r\n       #!!!!!!!!#!!!!!!!!!!!#!!!!!!!#***!!!!***!!!!**********#\r\n      #!!!!!!!!!!#!!!!!!!!!#!!!!!!!#****!!!!!*!!!!!!!!!!*****#\r\n      #!!!!!!!!!!!#!!!!!!!#!!!!!!!#*!!***!!!!!!!!!!!!!!!!!***#\r\n      #!!!!!!!!!!!!#!!!!!!#!!!!!!#*!!!!!*!!!!!!!!!!!!!!!*****#\r\n      #!!!!!!!!!!!!#!!!!!!#!!!!!#***!!!!!!!!!!!!!!!!!********#\r\n     #!!!!!!!!!!!!!#!!!!!!#!!!!!#****!!!!!!!!!!!!!!**********#\r\n     #!!!!!!!!!!!!!#!!!!!!#!!!!!#*****!!!!!!!!!!!!!!*********#\r\n     #!!!!!!!!!!!!!#!!!!!!#!!!!!#***!!!!!!!!!!!!!!!!!********##\r\n    ##!!!!!!!!!!!!!#!!!!!!#!!!!!#*!!!!!!!!!!!!!!!!!!!!!*****#!*##\r\n   #!#!!!!!!!!######!!!!!!#!!!!!#**!!!!!!!!!!#########!!!!*#!!**##\r\n  #!#!#!!!!!!#!!!!!!!!!!!!#!!!!!#***!!!!!####******!!!#######!!**#\r\n #!#!!##!!!!#!!!!!!!!!!!############*!!!#********!!!!!!!!!!!!!!!**#\r\n #!#!!#!#!!#!!!#!!!!!!!#!!!!!!!!!!!!!!!#***********!!!!!!!!!!!!!!!#\r\n #!#!!!#!#!#!!#!!!!!!!#!!!!#!!!!#!!!!!#**********!!!!!!!!!!!!!!!**#\r\n #!!#!!!#!##!!#!!!!!!#!!!!#!!!!#!!!!!!#************!!!!!!!!!!****#\r\n  ######### ##########!!!!#!!!!#!!!!!!#**********!!!!!!!!!!!!***#\r\n                      #################************!!!!!!!!!!**#\r\n                                      #**********!!!!!#########\r\n                                       ###############"]