Audacious crashes with **buffer overflow detected** on certain music file.

[catscarlet]

Well I can't get registered on your redmine because I can't receive the activating email so I will just post it here.

• Platform: Linux Mint 20.3 Cinnamon (Based on Ubuntu 20.04)
• Version: 4.3.1-0build1~ubuntu2004, installed by using apt from ppa:ubuntuhandbook1/apps

When trying to open these certain files, audacious just crashes. All I can do was audacious -V , get the log and the coredump file.
So far what I got is *** buffer overflow detected ***: terminated

logs:

Click me

cat@cat-B85M-D3H:~/Documents/app$ audacious -V
INFO dbus-server.cc:1132 [name_acquired]: Owned D-Bus name (org.atheme.audacious) on session bus.
INFO main.cc:399 [main]: No remote session; starting up.
INFO probe-buffer.cc:30 [ProbeBuffer]: <0x562fed252570> buffering enabled for /home/cat/.config/audacious/config
INFO vfs.cc:105 [VFSFile]: <0x562fed252570> open (mode r) /home/cat/.config/audacious/config
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/Transport/gio.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/Transport/mms.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/Transport/neon.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/Container/asx.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/Container/asx3.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/Container/audpl.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/Container/cue.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/Container/m3u.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/Container/pls.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/Container/xspf.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/Input/aac-raw.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/Input/amidi-plug.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/Input/cdaudio-ng.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/Input/console.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/Input/ffaudio.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/Input/flacng.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/Input/madplug.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/Input/metronom.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/Input/modplug.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/Input/opus.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/Input/psf2.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/Input/sndfile.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/Input/tonegen.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/Input/vorbis.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/Input/vtx.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/Input/wavpack.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/Input/xsf.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/Output/alsa.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/Output/filewriter.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/Output/jack-ng.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/Output/oss4.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/Output/pulse_audio.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/Output/sdlout.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/Effect/bitcrusher.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/Effect/bs2b.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/Effect/compressor.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/Effect/crossfade.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/Effect/crystalizer.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/Effect/echo.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/Effect/ladspa.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/Effect/mixer.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/Effect/resample.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/Effect/silence-removal.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/Effect/sox-resampler.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/Effect/speed-pitch.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/Effect/stereo.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/Effect/voice_removal.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/General/albumart-qt.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/General/albumart.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/General/aosd.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/General/cd-menu-items.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/General/delete-files.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/General/gtkui.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/General/hotkey.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/General/lirc.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/General/lyricwiki-qt.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/General/mpris2.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/General/notify.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/General/playlist-manager-qt.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/General/playlist-manager.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/General/qtui.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/General/scrobbler.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/General/search-tool-qt.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/General/search-tool.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/General/skins-qt.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/General/skins.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/General/song-info-qt.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/General/song_change.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/General/statusicon-qt.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/General/statusicon.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/Visualization/blur_scope-qt.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/Visualization/blur_scope.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/Visualization/cairo-spectrum.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/Visualization/gl-spectrum.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/Visualization/qt-spectrum.so
INFO plugin-registry.cc:546 [plugin_register]: Register plugin: /usr/lib/x86_64-linux-gnu/audacious/Visualization/vumeter-qt.so
INFO plugin-registry.cc:436 [operator()]: Incompatible plugin flags: blur_scope
INFO plugin-registry.cc:436 [operator()]: Incompatible plugin flags: gl-spectrum
INFO plugin-registry.cc:436 [operator()]: Incompatible plugin flags: cairo-spectrum
INFO plugin-registry.cc:436 [operator()]: Incompatible plugin flags: albumart
INFO plugin-registry.cc:436 [operator()]: Incompatible plugin flags: aosd
INFO plugin-registry.cc:436 [operator()]: Incompatible plugin flags: hotkey
INFO plugin-registry.cc:436 [operator()]: Incompatible plugin flags: playlist-manager
INFO plugin-registry.cc:436 [operator()]: Incompatible plugin flags: search-tool
INFO plugin-registry.cc:436 [operator()]: Incompatible plugin flags: statusicon
INFO plugin-registry.cc:436 [operator()]: Incompatible plugin flags: gtkui
INFO plugin-registry.cc:436 [operator()]: Incompatible plugin flags: skins
INFO plugin-init.cc:133 [start_required]: Starting selected output plugin PulseAudio Output.
INFO plugin-load.cc:64 [plugin_load]: Loading plugin: /usr/lib/x86_64-linux-gnu/audacious/Output/pulse_audio.so.
INFO probe-buffer.cc:30 [ProbeBuffer]: <0x562fed279fb0> buffering enabled for /home/cat/.config/audacious/playlists/order
INFO vfs.cc:105 [VFSFile]: <0x562fed279fb0> open (mode r) /home/cat/.config/audacious/playlists/order
INFO playlist-files.cc:49 [playlist_load]: Loading playlist file:///home/cat/.config/audacious/playlists/1000.audpl.
INFO playlist-files.cc:62 [playlist_load]: Trying playlist plugin Audacious Playlists (audpl).
INFO plugin-load.cc:64 [plugin_load]: Loading plugin: /usr/lib/x86_64-linux-gnu/audacious/Container/audpl.so.
INFO probe-buffer.cc:30 [ProbeBuffer]: <0x562fed274b20> buffering enabled for file:///home/cat/.config/audacious/playlists/1000.audpl
INFO vfs.cc:105 [VFSFile]: <0x562fed274b20> open (mode r) file:///home/cat/.config/audacious/playlists/1000.audpl
INFO plugin-init.cc:188 [start_plugins]: Starting Audio CD Menu Items.
INFO plugin-load.cc:64 [plugin_load]: Loading plugin: /usr/lib/x86_64-linux-gnu/audacious/General/cd-menu-items.so.
INFO plugin-init.cc:188 [start_plugins]: Starting MPRIS 2 Server.
INFO plugin-load.cc:64 [plugin_load]: Loading plugin: /usr/lib/x86_64-linux-gnu/audacious/General/mpris2.so.
INFO plugin-init.cc:133 [start_required]: Starting selected interface plugin Qt Interface.
INFO plugin-load.cc:64 [plugin_load]: Loading plugin: /usr/lib/x86_64-linux-gnu/audacious/General/qtui.so.
INFO interface.cc:70 [interface_load]: Loading Qt Interface.
qt5ct: using qt5ct plugin
qt5ct: D-Bus global menu: no



INFO adder.cc:142 [add_file]: Adding file: file:///media/cat/Temp/Output/FFMPEG/oppo_x1/09.aac
INFO probe.cc:89 [aud_file_find_decoder]: Probing file:///media/cat/Temp/Output/FFMPEG/oppo_x1/09.aac.
INFO probe.cc:115 [aud_file_find_decoder]: Matched AAC (Raw) Decoder by extension.
INFO plugin-load.cc:64 [plugin_load]: Loading plugin: /usr/lib/x86_64-linux-gnu/audacious/Input/aac-raw.so.
INFO probe-buffer.cc:30 [ProbeBuffer]: <0x7f7368001580> buffering enabled for file:///media/cat/Temp/Output/FFMPEG/oppo_x1/09.aac
INFO vfs.cc:105 [VFSFile]: <0x7f7368001580> open (mode r) file:///media/cat/Temp/Output/FFMPEG/oppo_x1/09.aac
INFO probe-buffer.cc:50 [release_buffer]: <0x7f7368001580> buffering disabled for file:///media/cat/Temp/Output/FFMPEG/oppo_x1/09.aac
INFO probe-buffer.cc:134 [fseek]: <0x7f7368001580> buffering enabled for file:///media/cat/Temp/Output/FFMPEG/oppo_x1/09.aac
*** buffer overflow detected ***: terminated
Aborted (core dumped)
cat@cat-B85M-D3H:~/Documents/app$ 

The music sample and the coredump file:

Click me

• Music sample: https://mega.nz/file/S8dgDI4D#C0UaIebxkB32c9yQXquZ4v5ENk-m1ByHMyYc_K7hyJg
• Coredump file: https://mega.nz/file/X00jXDSZ#lNhj51jTQ_LTfYkmhE1C40vVLh4_JRje08f2Ldewpw0

If you have trouble downloading these files. Just tell me. I can try another netdisk.

[radioactiveman]

Thanks for the sample file, I can reproduce the crash with Audacious. Other applications like VLC and Qmmp are able to play the file.

@jlindgren90: The issue here with this (probably corrupt) file is that NeAACDecInit() returns an error (-1). Without checking for it, buflen then exceeds the actual buffer size, resulting in an overflow in memmove(). Qmmp handles this properly (2nd link) but can play the same file anyway. I don't understand yet why. Could you please take a closer look?

• https://github.com/audacious-media-player/audacious-plugins/blob/1bce3bd834d9b03093dd/src/aac/aac.cc#L391-L396
• https://sourceforge.net/p/qmmp-dev/code/HEAD/tree/branches/qmmp-2.1/src/plugins/Input/aac/decoder_aac.cpp#l107

[radioactiveman]

The sample file is corrupt and has an invalid ADTS header. Qmmp can play it only with the FFmpeg plugin. When disabled, the AAC decoder plugin is used which then fails as expected.

To avoid the crash in Audacious I have submitted this pull request.