GTK3 popupinfo window color consistency and systray consistency

[dmillfree868]

I noticed If I compile audacious with gtk3 that the popupinfo window is light gray with black text. Shouldn't this be more consistent with the same look and colors as the gtk2 version or the qt version? The qt version the size of the popupinfo window is too big and the systray icon shows no popupinfo windows at all. I know there is ongoing development so it's understandable.

[jlindgren90]

GTK3 broke a lot of custom theming, that's one of the reasons we avoided it for a long time.

[radioactiveman]

Regarding the missing popup info for the Qt status icon: The code to handle this is there but the event method seems to be never called.
Does this work on your machine @jlindgren90? Maybe it's related to the desktop environment.

[dmillfree868]

I was thinking the same thing. I have audacious installed on Slackware Linux using the xfce4 desktop. Slackware offers the KDE desktop which is Qt based but I don't install that or use it.

…

On Sun, Dec 3, 2023, 6:54 AM Thomas Lange ***@***.***> wrote: Regarding the missing popup info for the Qt status icon: The code to handle this is there but the event method <https://github.com/audacious-media-player/audacious-plugins/blob/a5d02335b02fdf9cfc6815a33e7be3812e0d6f24/src/statusicon-qt/statusicon.cc#L158-L174> seems to be never called. Does this work on your machine @jlindgren90 <https://github.com/jlindgren90>? Maybe it's related to the desktop environment. — Reply to this email directly, view it on GitHub <#92 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AWYUH5KP3TOPPOXNXBHEL3LYHRR6JAVCNFSM6AAAAABAEEEECWVHI2DSMVQWIX3LMV43SRDJONRXK43TNFXW4Q3PNVWWK3TUHM3TONBTGMZDA> . You are receiving this because you authored the thread.Message ID: <audacious-media-player/audacious/repo-discussions/92/comments/7743320@ github.com>

[jlindgren90]

Qt is probably using StatusNotifierItem rather than XEmbed for the status icon. SNI doesn't support all the same event types as XEmbed.

[Npa972]

Changing the volume with the mouse also don't work with qt version.
Actually i use a gtk3 git version and i can't see the colors problem in the popup windows (playlist or systray icon). Perhaps because i use a dark theme ?
Changing the volume on systray works fine with gtk3.
And the new hamburger menu is nice with symbolic icons.
System : archlinux with xfce, papirus-icon-theme and adwaita-dark
Another thing is gtk3 version consume much less memory than qt version.
Thanks to the developpers

[Npa972]

[Npa972]

@dmillfree868, ok i understand now what you mean :
audacious-git gtk2 : black background with gradient and with white text

audacious-git gtk3 : light gray background without gradient and with black text. It's less visible with a dark theme

[dmillfree868]

Sorry I should have posted a screenshot. I actually took the time to install KDE temporarily (Yikes what a mess) and that made no difference with qt modes tray icon. I just reverted back to building audacious with gtk2. Problem solved.

[radioactiveman]

The GTK3 info popup now looks the same as with GTK2 / Qt, implemented with fcdb46d.

[dmillfree868]

Wow you guys are awesome, your work is really appreciated.

[Npa972]

I built the latest version with gtk3 and it's perfect.
Thank's