Skip to content

Use new libsidplay API for SID plugin #1706

@radioactiveman

Description

@radioactiveman

Description
libsidplay 2.14 introduced a new play API. The play() function we use was deprecated, leading to this warning:

[1/2] Compiling C++ object src/sid/sid.so.p/xs_sidplay2.cc.o
../src/sid/xs_sidplay2.cc: In function ‘unsigned int xs_sidplayfp_fillbuffer(char*, unsigned int)’:
../src/sid/xs_sidplay2.cc:223:31: warning: ‘uint_least32_t sidplayfp::play(short int*, uint_least32_t)’ is deprecated [-Wdeprecated-declarations]
  223 |     return state.currEng->play((short *)audioBuffer, audioBufSize / 2) * 2;
      |            ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../src/sid/xs_sidplay2.cc:33:
/usr/include/sidplayfp/sidplayfp.h:115:20: note: declared here
  115 |     uint_least32_t play(short *buffer, uint_least32_t count);
      |                    ^~~~

Since I don't understand how to migrate our SID plugin to the new API, I file it here as feature request.
@jlindgren90: Maybe you want to take care of it?

Additional information

Metadata

Metadata

Assignees

No one assigned

    Labels

    EnhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions