Skip to content

Commit 6ee4002

Browse files
authored
Merge pull request #24 from PGHM/optimize_user_agent_handling
Optimize user agent handling
2 parents 2cd434a + e9abfbc commit 6ee4002

File tree

3 files changed

+6
-54
lines changed

3 files changed

+6
-54
lines changed

UserReport/UserReport/Network/Network.swift

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,8 @@ internal class Network {
3838
let logger: Logger
3939
var testMode: Bool
4040

41-
private let userAgent = UserAgent()
41+
private static let userAgent = WKWebView().value(forKey: "userAgent") as? String
42+
4243
private let server = Server()
4344
private let session: URLSession
4445

@@ -110,16 +111,10 @@ internal class Network {
110111
let allowedCharacters = CharacterSet(charactersIn: " ").inverted
111112
guard let url = urlString.addingPercentEncoding(withAllowedCharacters: allowedCharacters) else { return }
112113

113-
self.userAgent.fetch { [weak self] result in
114-
switch result {
115-
116-
case .success(let userAgent):
117-
self?.send(request: Request(.GET, url, ["User-Agent": userAgent]), completion)
118-
119-
case .failure(let error):
120-
self?.logger.log("Error to found User agent: \(error.localizedDescription)", level: .error)
121-
completion(.failure(error))
122-
}
114+
if let userAgent = Network.userAgent {
115+
send(request: Request(.GET, url, ["User-Agent": userAgent]), completion)
116+
} else {
117+
send(request: Request(.GET, url), completion)
123118
}
124119
}
125120

UserReport/UserReport/Network/UserAgent.swift

Lines changed: 0 additions & 39 deletions
This file was deleted.

UserReport/UserReportSDK.xcodeproj/project.pbxproj

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@
3131
116BD16C1F5819D400D2386B /* SerializableObject.swift in Sources */ = {isa = PBXBuildFile; fileRef = 116BD16B1F5819D400D2386B /* SerializableObject.swift */; };
3232
11C71E9A1F6966040081D9B4 /* Session.swift in Sources */ = {isa = PBXBuildFile; fileRef = 11C71E991F6966040081D9B4 /* Session.swift */; };
3333
2CBD092B26F201D9009E3463 /* String+Request.swift in Sources */ = {isa = PBXBuildFile; fileRef = 2CBD092A26F201D9009E3463 /* String+Request.swift */; };
34-
2CBD092D26F201F6009E3463 /* UserAgent.swift in Sources */ = {isa = PBXBuildFile; fileRef = 2CBD092C26F201F6009E3463 /* UserAgent.swift */; };
3534
2CBD092F26F2024C009E3463 /* Request.swift in Sources */ = {isa = PBXBuildFile; fileRef = 2CBD092E26F2024C009E3463 /* Request.swift */; };
3635
8A4CF05A23D5D2860081C2D8 /* QuarantineRequest.swift in Sources */ = {isa = PBXBuildFile; fileRef = 8A4CF05923D5D2860081C2D8 /* QuarantineRequest.swift */; };
3736
8A4CF05C23D5D2960081C2D8 /* QuarantineResponse.swift in Sources */ = {isa = PBXBuildFile; fileRef = 8A4CF05B23D5D2960081C2D8 /* QuarantineResponse.swift */; };
@@ -77,7 +76,6 @@
7776
116BD16B1F5819D400D2386B /* SerializableObject.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = SerializableObject.swift; sourceTree = "<group>"; };
7877
11C71E991F6966040081D9B4 /* Session.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = Session.swift; sourceTree = "<group>"; };
7978
2CBD092A26F201D9009E3463 /* String+Request.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "String+Request.swift"; sourceTree = "<group>"; };
80-
2CBD092C26F201F6009E3463 /* UserAgent.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = UserAgent.swift; sourceTree = "<group>"; };
8179
2CBD092E26F2024C009E3463 /* Request.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = Request.swift; sourceTree = "<group>"; };
8280
8A4CF05923D5D2860081C2D8 /* QuarantineRequest.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = QuarantineRequest.swift; sourceTree = "<group>"; };
8381
8A4CF05B23D5D2960081C2D8 /* QuarantineResponse.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = QuarantineResponse.swift; sourceTree = "<group>"; };
@@ -146,7 +144,6 @@
146144
children = (
147145
110747361F46FA6800150955 /* Network.swift */,
148146
110747551F4C76B200150955 /* URError.swift */,
149-
2CBD092C26F201F6009E3463 /* UserAgent.swift */,
150147
);
151148
path = Network;
152149
sourceTree = "<group>";
@@ -347,7 +344,6 @@
347344
buildActionMask = 2147483647;
348345
files = (
349346
8AE372B32408057700ED3AE0 /* Data+Hashing.swift in Sources */,
350-
2CBD092D26F201F6009E3463 /* UserAgent.swift in Sources */,
351347
110747411F46FD1900150955 /* Logger.swift in Sources */,
352348
110747541F4C766E00150955 /* Invitation.swift in Sources */,
353349
8A4CF05A23D5D2860081C2D8 /* QuarantineRequest.swift in Sources */,

0 commit comments

Comments
 (0)