Merge pull request #28 from DevFactory/release/Dead-stores-should-be-removed-fix1

Fixing squid:S1854- Dead stores should be removed

Author: janithb

src/main/java/org/audit4j/core/Configurations.java

@@ -92,8 +92,8 @@ static Configuration loadConfig(ConfigurationStream stream) throws Configuration
      * @throws ConfigurationException the configuration exception
      */
     static ConfigurationStream resolveConfigFileAsStream(String configFilePath) throws ConfigurationException {
-        InputStream fileStream = null;
-        String fileExtention = null;
+        InputStream fileStream;
+        String fileExtention;
 
         if (configFilePath != null) {
             if (new File(configFilePath).isDirectory()) {
@@ -142,7 +142,7 @@ static String scanConfigFile(String dirPath) throws ConfigurationException {
 
         String filePath = dirPath + File.separator + CONFIG_FILE_NAME + ".";
 
-        String fullFilePath = null;
+        String fullFilePath;
         // Scan for Yaml file
         if (AuditUtil.isFileExists(filePath + YML_EXTENTION)) {
             fullFilePath = filePath + YML_EXTENTION;
@@ -182,7 +182,7 @@ static void generateConfigFile(String configFilePath) throws ConfigurationExcept
      * @throws ConfigurationException 
      */
     private static ConfigProvider<Configuration> getProviderByFileExtention(String extention) throws ConfigurationException {
-        ConfigProvider<Configuration> provider = null;
+        ConfigProvider<Configuration> provider;
         if (XML_EXTENTION.equals(extention)) {
             provider = new XMLConfigProvider<>(Configuration.class);
         } else if (YML_EXTENTION.equals(extention) || YAML_EXTENTION.equals(extention)) {

src/main/java/org/audit4j/core/annotation/AuditFieldAnnotationAttribute.java

@@ -52,7 +52,7 @@ public List<Field> getAllFields(final Method method, final Object[] arg1) {
 		int i = 0;
 		String paramName = null;
 		String paramValue = null;
-		Class<?> paramType = null;
+		Class<?> paramType;
 		for (final Annotation[] annotations : parameterAnnotations) {
 			final Object object = arg1[i++];
 			//paramValue = ObjectToStringSerializer.(object);
@@ -99,7 +99,7 @@ public List<Field> getMarkedFields(final Method method, final Object[] arg1) {
 		int i = 0;
 		String paramName = null;
 		String paramValue = null;
-		Class<?> paramType = null;
+		Class<?> paramType;
 		for (final Annotation[] annotations : parameterAnnotations) {
 			final Object object = arg1[i++];
 			//paramValue = ObjectToStringSerializer.toStringIfNotImplemented(object);

src/main/java/org/audit4j/core/annotation/DeIdentifyUtil.java

@@ -47,7 +47,7 @@ private DeIdentifyUtil(){
 	 * @since 2.0.0
 	 */
 	public static String deidentifyLeft(String str, int size) {
-		int repeat = 0;
+		int repeat;
 		if (size > str.length()) {
 			repeat = str.length();
 		} else {
@@ -67,7 +67,7 @@ public static String deidentifyLeft(String str, int size) {
 	 */
 	public static String deidentifyRight(String str, int size) {
 		int end = str.length();
-		int repeat = 0;
+		int repeat;
 		if (size > str.length()) {
 			repeat = str.length();
 		} else {
@@ -87,7 +87,7 @@ public static String deidentifyRight(String str, int size) {
 	 */
 	public static String deidentifyFromLeft(String str, int size) {
 		int end = str.length();
-		int repeat = 0;
+		int repeat;
 		if (size > str.length()) {
 			repeat = 0;
 		} else {
@@ -107,7 +107,7 @@ public static String deidentifyFromLeft(String str, int size) {
 	 */
 	public static String deidentifyFromRight(String str, int size) {
 		int end = str.length();
-		int repeat = 0;
+		int repeat;
 		if (size > str.length()) {
 			repeat = str.length();
 		} else {
@@ -128,7 +128,7 @@ public static String deidentifyFromRight(String str, int size) {
 	 */
 	public static String deidentifyMiddle(String str, int start, int end) {
 
-		int repeat = 0;
+		int repeat;
 		if (end - start > str.length()) {
 			repeat = str.length();
 		} else {