Add collision detection algorithms for basic shapes #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements collision detection between: - Circles - Rectangles (using AABB) - Circle and Rectangle Includes: - Well-documented implementation - Comprehensive unit tests - Type hints and docstrings Fixes #1
|
This did not conform to the convention of the repo. Testing should be done in the main block of the script itself, not a separate file. |
- Remove separate test file - Add comprehensive doctests - Add example usage in main block - Follow project's testing convention
- Sort imports - Fix line lengths - Remove trailing whitespace - Fix type annotations - Clean up list comprehensions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements collision detection algorithms for basic geometric shapes as requested in #1.
Implements:
Features:
All tests are passing. The implementation follows project code style and conventions.
Fixes #1