Merge pull request #161 from auraphp/fix/php84-nullable-parameter

harikt · web-flow · commit 56157d3dfdee · 2025-11-25T12:59:16.000+05:30
Fix PHP 8.4 deprecation in AbstractStrlen::substr()
diff --git a/src/Rule/AbstractStrlen.php b/src/Rule/AbstractStrlen.php
@@ -138,7 +138,7 @@ protected function strlenIconv(string $str): int
      * @return string
      *
      */
-    protected function substr(string $str, int $start, int $length = null): string
+    protected function substr(string $str, int $start, ?int $length = null): string
     {
         if ($this->iconv()) {
             return $this->substrIconv($str, $start, $length);

Original file line number	Diff line number	Diff line change
`@@ -138,7 +138,7 @@ protected function strlenIconv(string $str): int`
`138`	`138`	`* @return string`
`139`	`139`	`*`
`140`	`140`	`*/`
`141`		`- protected function substr(string $str, int $start, int $length = null): string`
	`141`	`+ protected function substr(string $str, int $start, ?int $length = null): string`
`142`	`142`	`{`
`143`	`143`	`if ($this->iconv()) {`
`144`	`144`	`return $this->substrIconv($str, $start, $length);`