Encoded '&' in view parameters does not reach 'activate'

[MaximBalaganskiy]

I'm submitting a bug report

• Library Version:
  1.3.2

Please tell us about your environment:

• Operating System:
  Windows 10

• Node Version:
  8.9.4

• NPM Version:
  6.9.0

• JSPM OR Webpack AND Version
  webpack 4.30.0

• Browser:
  all

• Language:
  all

Current behavior:
Passing a=b%26c as a view query results in {a: 'b', c: true} object

Expected/desired behavior:

• What is the expected behavior?
  Passing a=b%26c as a view query results in {a: 'b&c'} object

• What is the motivation / use case for changing the behavior?
  An encoded parameter value is expected to reach a view unchanged

[MaximBalaganskiy]

This is happening because the latest version decodes a fragment before passing it to aurelia-path

[MaximBalaganskiy]

Also related to aurelia/path#30

[davismj]

Seems like it might be a pretty difficult thing to work around. If you go set up a gist.run or codesandbox that I could use for debugging that would help me diagnose and prescribe a solution.

[MaximBalaganskiy]

This worked until fragment decoding started happening in 1.3.2.
Not sure if I can pass parameters to views in a gist - it's executed in a frame...

[MaximBalaganskiy]

Here is the gist forked from the issue template, but it does not use the latest of the aurelia-browser-history and & and + are parsed fine
https://gist.run/?id=0ac69daa2930333a9064242a4f9ff4ab

[salminio]

I'm hitting something similar but my character is a % sign which when decoded twice causes an internal error... Browser history is decoding it and then route recognize tries again causing a malformed error

vendor-bundle-8.5.0-1558258139.js:formatted:8422 Unhandled promise rejection URIError: URI malformed
at decodeURI ()
at e [as recognize] (vendor-bundle-8.5.0-1558258139.js:formatted:26612)
at t.e._createNavigationInstruction (vendor-bundle-8.5.0-1558258139.js:formatted:27447)
at t.loadUrl (vendor-bundle-8.5.0-1558258139.js:formatted:28323)
at t._loadUrl (vendor-bundle-8.5.0-1558258139.js:formatted:21586)
at t.navigate (vendor-bundle-8.5.0-1558258139.js:formatted:21514)
at t.e.navigate (vendor-bundle-8.5.0-1558258139.js:formatted:27261)
at e [as _navigate] (thingworx-ui-bundle-8.5.0-1558258139.js:formatted:43386)
at thingworx-ui-bundle-8.5.0-1558258139.js:formatted:43122
at vendor-bundle-8.5.0-1558258139.js:formatted:8401
at vendor-bundle-8.5.0-1558258139.js:formatted:8409
at MutationObserver.u (vendor-bundle-8.5.0-1558258139.js:formatted:5370)

[davismj]

fixed by #53