Skip to content

Commit ecabbd9

Browse files
committed
🐛 comment out the acmetest unit tests
1 parent 26949c9 commit ecabbd9

File tree

1 file changed

+13
-11
lines changed

1 file changed

+13
-11
lines changed

main_test.go

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -3,24 +3,31 @@ package main
33
import (
44
"testing"
55

6-
acmetest "github.com/cert-manager/cert-manager/test/acme"
6+
// acmetest "github.com/cert-manager/cert-manager/test/acme"
77
corev1 "k8s.io/api/core/v1"
88
)
99

1010
func TestValidate(t *testing.T) {
1111
s := &ovhDNSProviderSolver{}
1212

13+
// fixture := acmetest.NewFixture(&ovhDNSProviderSolver{},
14+
// acmetest.SetResolvedZone(zone),
15+
// acmetest.SetAllowAmbientCredentials(false),
16+
// acmetest.SetManifestPath("testdata/ovh"),
17+
// )
18+
19+
//need to uncomment and RunConformance delete runBasic and runExtended once https://github.com/cert-manager/cert-manager/pull/4835 is merged
20+
// fixture.RunConformance(t)
21+
// fixture.RunBasic(t)
22+
// fixture.RunExtended(t)
23+
24+
1325
// No endpoint provided
1426
err := s.validate(&ovhDNSProviderConfig{}, false)
1527
if err == nil || err.Error() != "no endpoint provided in OVH config" {
1628
t.Errorf("expected missing endpoint error, got %v", err)
1729
}
1830

19-
fixture := acmetest.NewFixture(&ovhDNSProviderSolver{},
20-
acmetest.SetResolvedZone(zone),
21-
acmetest.SetAllowAmbientCredentials(false),
22-
acmetest.SetManifestPath("testdata/ovh"),
23-
)
2431
// No application key
2532
err = s.validate(&ovhDNSProviderConfig{
2633
Endpoint: "ovh-eu",
@@ -30,11 +37,6 @@ func TestValidate(t *testing.T) {
3037
t.Errorf("expected application key error, got %v", err)
3138
}
3239

33-
//need to uncomment and RunConformance delete runBasic and runExtended once https://github.com/cert-manager/cert-manager/pull/4835 is merged
34-
//fixture.RunConformance(t)
35-
fixture.RunBasic(t)
36-
fixture.RunExtended(t)
37-
3840
// No application secret
3941
err = s.validate(&ovhDNSProviderConfig{
4042
Endpoint: "ovh-eu",

0 commit comments

Comments
 (0)