Moves SetSolverOptions to bottom of ConstructJacobianSolver to fix bug.

The Jacobian solver and preconditioner were not set when SetSolverOptions was called!

Author: Edward Palmer

src/formulations/Dual/dual_formulation.cpp

@@ -215,11 +215,11 @@ DualOperator::ConstructJacobianSolver()
   auto solver = std::make_unique<mfem::HyprePCG>(_problem._comm);
   solver->SetPreconditioner(*precond);
 
-  SolverOptions default_options;
-  SetSolverOptions(default_options);
-
   _jacobian_preconditioner = std::move(precond);
   _jacobian_solver = std::move(solver);
+
+  auto default_options = SolverOptions();
+  SetSolverOptions(default_options);
 }
 
 void

src/formulations/HCurl/hcurl_formulation.cpp

@@ -98,11 +98,11 @@ HCurlProblemOperator::ConstructJacobianSolver()
   auto solver = std::make_unique<mfem::HyprePCG>(_problem._comm);
   solver->SetPreconditioner(*precond);
 
-  SolverOptions default_options;
-  SetSolverOptions(default_options);
-
   _jacobian_preconditioner = std::move(precond);
   _jacobian_solver = std::move(solver);
+
+  auto default_options = SolverOptions();
+  SetSolverOptions(default_options);
 }
 
 void

src/formulations/Magnetostatic/statics_formulation.cpp

@@ -109,11 +109,11 @@ StaticsOperator::ConstructJacobianSolver()
   auto solver = std::make_unique<mfem::HypreFGMRES>(_problem._comm);
   solver->SetPreconditioner(*precond);
 
-  SolverOptions default_options{._max_iteration = 100};
-  SetSolverOptions(default_options);
-
   _jacobian_preconditioner = std::move(precond);
   _jacobian_solver = std::move(solver);
+
+  SolverOptions default_options{._max_iteration = 100};
+  SetSolverOptions(default_options);
 }
 
 void

src/problem_operators/problem_operator_base.cpp

@@ -14,11 +14,11 @@ ProblemOperatorBase::ConstructJacobianSolver()
   auto solver = std::make_unique<mfem::HypreGMRES>(_problem._comm);
   solver->SetPreconditioner(*precond);
 
-  SolverOptions default_options;
-  SetSolverOptions(default_options);
-
   _jacobian_preconditioner = std::move(precond);
   _jacobian_solver = std::move(solver);
+
+  auto default_options = SolverOptions();
+  SetSolverOptions(default_options);
 }
 
 void