llama : fix signed comparison warning on FreeBSD (#17497)

angt · web-flow · commit f3a9674ae896 · 2025-12-02T12:05:38.000+01:00
This ensures correct RLIM_INFINITY handling and compatibility on all platforms (32/64-bit).

    warning: comparison of integers of different signs: 'rlim_t' (aka 'long') and 'size_t' (aka 'unsigned long') [-Wsign-compare]
      488 |         if (suggest &amp;&amp; (lock_limit.rlim_max &gt; lock_limit.rlim_cur + size)) {
          |                         ~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Adrien Gallouët &lt;angt@huggingface.co&gt;
diff --git a/src/llama-mmap.cpp b/src/llama-mmap.cpp
@@ -485,7 +485,7 @@ struct llama_mlock::impl {
         if (suggest && getrlimit(RLIMIT_MEMLOCK, &lock_limit)) {
             suggest = false;
         }
-        if (suggest && (lock_limit.rlim_max > lock_limit.rlim_cur + size)) {
+        if (suggest && ((uint64_t)lock_limit.rlim_max > (uint64_t)lock_limit.rlim_cur + size)) {
             suggest = false;
         }
 #endif

Original file line number	Diff line number	Diff line change
`@@ -485,7 +485,7 @@ struct llama_mlock::impl {`
`485`	`485`	`if (suggest && getrlimit(RLIMIT_MEMLOCK, &lock_limit)) {`
`486`	`486`	`suggest = false;`
`487`	`487`	`}`
`488`		`- if (suggest && (lock_limit.rlim_max > lock_limit.rlim_cur + size)) {`
	`488`	`+ if (suggest && ((uint64_t)lock_limit.rlim_max > (uint64_t)lock_limit.rlim_cur + size)) {`
`489`	`489`	`suggest = false;`
`490`	`490`	`}`
`491`	`491`	`#endif`