Refactor services and components: streamline imports, enhance type safety, and implement lifecycle hooks

Author: austenstone

backend/src/services/metrics.service.ts

@@ -25,7 +25,6 @@ class MetricsService {
       ...Object.getOwnPropertySymbols(dateFilter).length ? { date: dateFilter } : {}
     }
 
-    const include = [];
     const types = type ? (type as string).split(/[ ,]+/) : [];
     const findAlls = {} as {
       copilot_ide_code_completions: Promise<MetricDaily[]>,

backend/src/services/query.service.ts

@@ -2,7 +2,6 @@ import { CronJob, CronJobParams, CronTime } from 'cron';
 import logger from './logger.js';
 import { insertUsage } from '../models/usage.model.js';
 import SeatService, { SeatEntry } from '../services/copilot.seats.service.js';
-import { Endpoints } from '@octokit/types';
 import { Octokit } from 'octokit';
 import metricsService from './metrics.service.js';
 import { MetricDailyResponseType } from '../models/metrics.model.js';

frontend/src/app/database/database.component.ts

@@ -1,4 +1,4 @@
-import { ChangeDetectionStrategy, ChangeDetectorRef, Component, ViewChild } from '@angular/core';
+import { AfterViewInit, ChangeDetectionStrategy, ChangeDetectorRef, Component, ViewChild } from '@angular/core';
 import { MatStepper, MatStepperModule } from '@angular/material/stepper';
 import { FormControl, FormGroup, FormsModule, ReactiveFormsModule, Validators } from '@angular/forms';
 import { MatIconModule } from '@angular/material/icon';
@@ -39,7 +39,7 @@ import { SetupService } from '../services/api/setup.service';
   styleUrl: './database.component.scss',
   changeDetection: ChangeDetectionStrategy.OnPush,
 })
-export class DatabaseComponent {
+export class DatabaseComponent implements AfterViewInit {
   @ViewChild('stepper') private stepper!: MatStepper;
   status?: statusResponse;
   isDbConnecting = false;

frontend/src/app/database/db-loading.component.ts

@@ -1,7 +1,7 @@
 import { Component, OnDestroy, OnInit } from '@angular/core';
-import { InstallationStatus, SetupService } from '../services/api/setup.service';
+import { InstallationStatus } from '../services/api/setup.service';
 import { Router } from '@angular/router';
-import { finalize, Subscription, takeUntil, takeWhile, timer } from 'rxjs';
+import { finalize, Subscription, takeWhile, timer } from 'rxjs';
 import { MatProgressBarModule } from '@angular/material/progress-bar';
 import { InstallationsService } from '../services/api/installations.service';
 

frontend/src/app/highcharts.theme.ts

@@ -278,8 +278,8 @@ const theme: Highcharts.Options = {
             }
           }
         },
-      } as any
-    },
+      }
+    } as Highcharts.NavigationButtonOptions,
     menuStyle: {
       background: 'var(--sys-surface-container)',
       color: 'var(--sys-on-surface)',

frontend/src/app/main/copilot/copilot-dashboard/dashboard-card/active-users-chart/active-users-chart.component.ts

@@ -1,4 +1,4 @@
-import { Component, Input } from '@angular/core';
+import { Component, Input, OnChanges } from '@angular/core';
 import { HighchartsChartModule } from 'highcharts-angular';
 import * as Highcharts from 'highcharts';
 import { Router } from '@angular/router';
@@ -14,7 +14,7 @@ import { Router } from '@angular/router';
     style="width: 200px; height: 200px;">
   </highcharts-chart>`
 })
-export class ActiveUsersChartComponent {
+export class ActiveUsersChartComponent implements OnChanges {
   @Input() data?: Record<string, number>;
   @Input() chartOptions?: Highcharts.Options;
   Highcharts: typeof Highcharts = Highcharts;

frontend/src/app/services/api/predictive-modeling.service.ts

@@ -2,6 +2,10 @@ import { Injectable } from '@angular/core';
 import { HttpClient } from '@angular/common/http';
 import { serverUrl } from '../server.service';
 
+export interface PredictiveModelingType {
+  number: number;
+}
+
 @Injectable({
   providedIn: 'root'
 })
@@ -11,14 +15,14 @@ export class PredictiveModelingService {
   constructor(private http: HttpClient) {}
 
   getTargets() {
-    return this.http.get<any>(`${this.apiUrl}/targets`);
+    return this.http.get<PredictiveModelingType>(`${this.apiUrl}/targets`);
   }
 
-  saveTargets(targets: any) {
-    return this.http.post<any>(`${this.apiUrl}/targets`, targets);
+  saveTargets(targets: PredictiveModelingType) {
+    return this.http.post<PredictiveModelingType>(`${this.apiUrl}/targets`, targets);
   }
 
   getCalculatedFields() {
-    return this.http.get<any>(`${this.apiUrl}/calculated-fields`);
+    return this.http.get<PredictiveModelingType>(`${this.apiUrl}/calculated-fields`);
   }
 }