Skip to content

Commit ca19185

Browse files
committed
fix: update return types for getMemberByLogin and getAllMembers methods in TeamsService
fix: change return type in getOrgMembers method of GithubService to use Member type
1 parent 836320e commit ca19185

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

backend/src/services/teams.service.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import { Endpoints } from "@octokit/types";
22
import mongoose from "mongoose";
33
import logger from "./logger.js";
4+
import { MemberType } from "models/teams.model.js";
45

56
class TeamsService {
67
async updateTeams(
@@ -137,14 +138,14 @@ class TeamsService {
137138
return team?.updatedAt || new Date(0);
138139
}
139140

140-
async getMemberByLogin(login: string) {
141+
async getMemberByLogin(login: string): Promise<MemberType> {
141142
const Member = mongoose.model("Member");
142143
return await Member.findOne({ login })
143144
.select("login name url avatar_url")
144145
.exec();
145146
}
146147

147-
async getAllMembers(org?: string) {
148+
async getAllMembers(org?: string): Promise<MemberType[]> {
148149
const Member = mongoose.model("Member");
149150
try {
150151
return await Member.find({

frontend/src/app/main/copilot/copilot-surveys/github.service.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import { Injectable } from '@angular/core';
22
import { HttpClient } from '@angular/common/http';
3+
import { Member } from '../../../services/api/members.service';
34

45
@Injectable({
56
providedIn: 'root'
@@ -10,6 +11,6 @@ export class GithubService {
1011
constructor(private http: HttpClient) {}
1112

1213
getOrgMembers() {
13-
return this.http.get<any[]>(`${this.apiUrl}/members`);
14+
return this.http.get<Member[]>(`${this.apiUrl}/members`);
1415
}
1516
}

0 commit comments

Comments
 (0)