Merge pull request #44 from auth0-lab/expected_update_undefined

fix: avoid undefined/null values in validityInfo.expectedUpdate

Author: jfromaniello

__tests__/issuing/deviceResponse.tests.ts

@@ -138,7 +138,7 @@ describe('issuing a device response', () => {
       expect(validityInfo.signed).toEqual(signed);
       expect(validityInfo.validFrom).toEqual(signed);
       expect(validityInfo.validUntil).toEqual(validUntil);
-      expect(validityInfo.expectedUpdate).toBeUndefined();
+      expect(validityInfo).not.toHaveProperty('expectedUpdate');
     });
 
     it('should contain the device namespaces', () => {
@@ -223,7 +223,7 @@ describe('issuing a device response', () => {
       expect(validityInfo.signed).toEqual(signed);
       expect(validityInfo.validFrom).toEqual(signed);
       expect(validityInfo.validUntil).toEqual(validUntil);
-      expect(validityInfo.expectedUpdate).toBeUndefined();
+      expect(validityInfo).not.toHaveProperty('expectedUpdate');
     });
 
     it('should contain the device namespaces', () => {

__tests__/issuing/deviceResponseWithMac.tests.ts

@@ -168,7 +168,7 @@ curves.forEach((c) => {
         expect(validityInfo.signed).toEqual(signed);
         expect(validityInfo.validFrom).toEqual(signed);
         expect(validityInfo.validUntil).toEqual(validUntil);
-        expect(validityInfo.expectedUpdate).toBeUndefined();
+        expect(validityInfo).not.toHaveProperty('expectedUpdate');
       });
 
       it('should contain the device namespaces', () => {
@@ -252,7 +252,7 @@ curves.forEach((c) => {
         expect(validityInfo.signed).toEqual(signed);
         expect(validityInfo.validFrom).toEqual(signed);
         expect(validityInfo.validUntil).toEqual(validUntil);
-        expect(validityInfo.expectedUpdate).toBeUndefined();
+        expect(validityInfo).not.toHaveProperty('expectedUpdate');
       });
 
       it('should contain the device namespaces', () => {

__tests__/issuing/issuingMDoc.tests.ts

@@ -20,6 +20,8 @@ describe('issuing an MDOC', () => {
   validFrom.setMinutes(signed.getMinutes() + 5);
   const validUntil = new Date(signed);
   validUntil.setFullYear(signed.getFullYear() + 30);
+  const expectedUpdate = new Date(signed);
+  expectedUpdate.setFullYear(signed.getFullYear() + 1);
 
   beforeAll(async () => {
     const issuerPrivateKey = ISSUER_PRIVATE_KEY_JWK;
@@ -53,6 +55,7 @@ describe('issuing an MDOC', () => {
         signed,
         validFrom,
         validUntil,
+        expectedUpdate,
       })
       .addDeviceKeyInfo({ deviceKey: publicKeyJWK })
       .sign({
@@ -86,7 +89,7 @@ describe('issuing an MDOC', () => {
     expect(validityInfo.signed).toEqual(signed);
     expect(validityInfo.validFrom).toEqual(validFrom);
     expect(validityInfo.validUntil).toEqual(validUntil);
-    expect(validityInfo.expectedUpdate).toBeUndefined();
+    expect(validityInfo.expectedUpdate).toEqual(expectedUpdate);
   });
 
   it('should use the correct digest alg', () => {