Skip to content

Commit 42e92cf

Browse files
authored
Merge branch 'main' into main
2 parents 288c2c9 + 12799c7 commit 42e92cf

File tree

3 files changed

+12
-10
lines changed

3 files changed

+12
-10
lines changed

EXAMPLES.md

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1288,12 +1288,9 @@ account.networkingClient = netClient
12881288
<summary>Using Java</summary>
12891289

12901290
```java
1291-
DefaultClient netClient = new DefaultClient(
1292-
connectTimeout = 30,
1293-
readTimeout = 30
1294-
);
1291+
DefaultClient netClient = new DefaultClient(30, 30);
12951292
Auth0 account = Auth0.getInstance("client id", "domain");
1296-
account.networkingClient = netClient;
1293+
account.setNetworkingClient(netClient);
12971294
```
12981295
</details>
12991296

@@ -1312,11 +1309,13 @@ account.networkingClient = netClient
13121309
<summary>Using Java</summary>
13131310

13141311
```java
1312+
import java.util.HashMap;
1313+
13151314
DefaultClient netClient = new DefaultClient(
1316-
enableLogging = true
1315+
10, 10, new HashMap<>() ,true
13171316
);
13181317
Auth0 account = Auth0.getInstance("client id", "domain");
1319-
account.networkingClient = netClient;
1318+
account.setNetworkingClient(netClient);
13201319
```
13211320
</details>
13221321

@@ -1339,10 +1338,10 @@ Map<String, String> defaultHeaders = new HashMap<>();
13391338
defaultHeaders.put("{HEADER-NAME}", "{HEADER-VALUE}");
13401339

13411340
DefaultClient netClient = new DefaultClient(
1342-
defaultHeaders = defaultHeaders
1341+
10,10 , defaultHeaders
13431342
);
13441343
Auth0 account = Auth0.getInstance("client id", "domain");
1345-
account.networkingClient = netClient;
1344+
account.setNetworkingClient(netClient);
13461345
```
13471346
</details>
13481347

@@ -1376,7 +1375,7 @@ class CustomNetClient extends NetworkingClient {
13761375
ServerResponse response = // ...
13771376

13781377
// Return a ServerResponse from the received response data
1379-
return ServerResponse(responseCode, responseBody, responseHeaders)
1378+
return new ServerResponse(responseCode, responseBody, responseHeaders);
13801379
}
13811380
};
13821381

README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -197,6 +197,8 @@ The callback will get invoked when the user returns to your application. There a
197197
198198
##### A note about App Deep Linking:
199199

200+
> Whenever possible, Auth0 recommends using [Android App Links](https://auth0.com/docs/applications/enable-android-app-links) as a secure way to link directly to content within your app. Custom URL schemes can be subject to [client impersonation attacks](https://datatracker.ietf.org/doc/html/rfc8252#section-8.6).
201+
200202
If you followed the configuration steps documented here, you may have noticed the default scheme used for the Callback URI is `https`. This works best for Android API 23 or newer if you're using [Android App Links](https://auth0.com/docs/applications/enable-android-app-links), but in previous Android versions this _may_ show the intent chooser dialog prompting the user to choose either your application or the browser. You can change this behaviour by using a custom unique scheme so that the OS opens directly the link with your app.
201203

202204
1. Update the `auth0Scheme` Manifest Placeholder on the `app/build.gradle` file or update the intent-filter declaration in the `AndroidManifest.xml` to use the new scheme.

auth0/src/main/java/com/auth0/android/request/DefaultClient.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ public class DefaultClient @VisibleForTesting(otherwise = VisibleForTesting.PRIV
3737
* @param defaultHeaders any headers that should be sent on all requests. If a specific request specifies a header with the same key as any header in the default headers, the header specified on the request will take precedence. Default is an empty map.
3838
* @param enableLogging whether HTTP request and response info should be logged. This should only be set to `true` for debugging purposes in non-production environments, as sensitive information is included in the logs. Defaults to `false`.
3939
*/
40+
@JvmOverloads
4041
public constructor(
4142
connectTimeout: Int = DEFAULT_TIMEOUT_SECONDS,
4243
readTimeout: Int = DEFAULT_TIMEOUT_SECONDS,

0 commit comments

Comments
 (0)