Skip to content

Commit d6026e4

Browse files
committed
Removed unwanted code added as part of initial implementation
1 parent abd631e commit d6026e4

File tree

8 files changed

+0
-73
lines changed

8 files changed

+0
-73
lines changed

auth0/src/main/java/com/auth0/android/request/ProfileRequest.kt

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -131,14 +131,6 @@ public class ProfileRequest
131131
return Authentication(profile, credentials)
132132
}
133133

134-
override fun getUrl(): String {
135-
return userInfoRequest.getUrl()
136-
}
137-
138-
override fun getHttpMethod(): HttpMethod {
139-
return userInfoRequest.getHttpMethod()
140-
}
141-
142134
private companion object {
143135
private const val HEADER_AUTHORIZATION = "Authorization"
144136
}

auth0/src/main/java/com/auth0/android/request/Request.kt

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ package com.auth0.android.request
22

33
import com.auth0.android.Auth0Exception
44
import com.auth0.android.callback.Callback
5-
import okhttp3.HttpUrl
65

76
/**
87
* Defines a request that can be started
@@ -77,17 +76,4 @@ public interface Request<T, U : Auth0Exception> {
7776
* @return itself
7877
*/
7978
public fun addHeader(name: String, value: String): Request<T, U>
80-
81-
82-
/**
83-
* Returns the URL of this request.
84-
* @return the URL
85-
*/
86-
public fun getUrl(): String
87-
88-
/**
89-
* Returns the [HttpMethod] of this request
90-
* @return the [HttpMethod]
91-
*/
92-
public fun getHttpMethod(): HttpMethod
9379
}

auth0/src/main/java/com/auth0/android/request/SignUpRequest.kt

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -120,15 +120,6 @@ public class SignUpRequest
120120
return this
121121
}
122122

123-
override fun getUrl(): String {
124-
return signUpRequest.getUrl()
125-
}
126-
127-
128-
override fun getHttpMethod(): HttpMethod {
129-
return signUpRequest.getHttpMethod()
130-
}
131-
132123
/**
133124
* Starts to execute create user request and then logs the user in.
134125
*

auth0/src/main/java/com/auth0/android/request/internal/BaseAuthenticationRequest.kt

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,7 @@ import com.auth0.android.authentication.AuthenticationException
88
import com.auth0.android.authentication.ParameterBuilder
99
import com.auth0.android.callback.Callback
1010
import com.auth0.android.provider.*
11-
import com.auth0.android.provider.IdTokenVerificationOptions
12-
import com.auth0.android.provider.IdTokenVerifier
1311
import com.auth0.android.request.AuthenticationRequest
14-
import com.auth0.android.request.HttpMethod
1512
import com.auth0.android.request.Request
1613
import com.auth0.android.result.Credentials
1714
import java.util.*
@@ -135,14 +132,6 @@ internal open class BaseAuthenticationRequest(
135132
return this
136133
}
137134

138-
override fun getHttpMethod(): HttpMethod {
139-
return request.getHttpMethod()
140-
}
141-
142-
override fun getUrl(): String {
143-
return request.getUrl()
144-
}
145-
146135
override fun start(callback: Callback<Credentials, AuthenticationException>) {
147136
warnClaimValidation()
148137
request.start(object : Callback<Credentials, AuthenticationException> {

auth0/src/main/java/com/auth0/android/request/internal/BaseRequest.kt

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,10 +70,6 @@ internal open class BaseRequest<T, U : Auth0Exception>(
7070
return this
7171
}
7272

73-
override fun getUrl(): String = url
74-
75-
override fun getHttpMethod(): HttpMethod = method
76-
7773
/**
7874
* Runs asynchronously and executes the network request, without blocking the current thread.
7975
* The result is parsed into a <T> value and posted in the callback's onSuccess method or a <U>

auth0/src/test/java/com/auth0/android/authentication/request/AuthenticationRequestMock.java

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
import com.auth0.android.authentication.AuthenticationException;
77
import com.auth0.android.callback.Callback;
88
import com.auth0.android.request.AuthenticationRequest;
9-
import com.auth0.android.request.HttpMethod;
109
import com.auth0.android.request.Request;
1110
import com.auth0.android.result.Credentials;
1211

@@ -113,16 +112,4 @@ public AuthenticationRequest withIdTokenVerificationLeeway(int leeway) {
113112
public AuthenticationRequest withIdTokenVerificationIssuer(@NonNull String issuer) {
114113
return this;
115114
}
116-
117-
@NonNull
118-
@Override
119-
public String getUrl() {
120-
return "";
121-
}
122-
123-
@NonNull
124-
@Override
125-
public HttpMethod getHttpMethod() {
126-
return HttpMethod.GET.INSTANCE;
127-
}
128115
}

auth0/src/test/java/com/auth0/android/authentication/request/ProfileRequestTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,6 @@ public class ProfileRequestTest {
4444
@Before
4545
public void setUp() {
4646
userInfoMockRequest = mock(Request.class);
47-
when(userInfoMockRequest.getHttpMethod()).thenReturn(HttpMethod.GET.INSTANCE);
48-
when(userInfoMockRequest.getUrl()).thenReturn("www.api.com/example");
4947
authenticationMockRequest = mock(AuthenticationRequest.class);
5048
profileRequest = new ProfileRequest(authenticationMockRequest, userInfoMockRequest);
5149
}

auth0/src/test/java/com/auth0/android/authentication/request/RequestMock.java

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -41,18 +41,6 @@ public Request<T, U> addHeader(@NonNull String name, @NonNull String value) {
4141
return this;
4242
}
4343

44-
@NonNull
45-
@Override
46-
public String getUrl() {
47-
return "";
48-
}
49-
50-
@NonNull
51-
@Override
52-
public HttpMethod getHttpMethod() {
53-
return HttpMethod.GET.INSTANCE;
54-
}
55-
5644
@Override
5745
public void start(@NonNull Callback<T, U> callback) {
5846
started = true;

0 commit comments

Comments
 (0)