Skip to content

Commit dc25fc6

Browse files
tanya732tanya732
committed
fixed test cases
1 parent cb38e8f commit dc25fc6

File tree

4 files changed

+322
-327
lines changed

4 files changed

+322
-327
lines changed

‎build.gradle‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ oss {
2020
repository 'auth0-java-mvc-common'
2121
organization 'auth0'
2222
description 'Java library that simplifies the use of Auth0 for server-side MVC web apps'
23-
baselineCompareVersion '1.5.0'
23+
// baselineCompareVersion '1.5.0'
2424
skipAssertSigningConfiguration true
2525

2626
developers {

‎src/test/java/com/auth0/AuthenticationControllerTest.java‎

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,7 @@
11
package com.auth0;
22

3-
import com.auth0.client.HttpOptions;
43
import com.auth0.client.auth.AuthAPI;
5-
import com.auth0.client.auth.AuthorizeUrlBuilder;
6-
import com.auth0.json.auth.TokenHolder;
74
import com.auth0.jwk.JwkProvider;
8-
import com.auth0.net.Telemetry;
9-
import com.auth0.net.TokenRequest;
105
import org.junit.jupiter.api.BeforeEach;
116
import org.junit.jupiter.api.Test;
127
import org.mockito.ArgumentCaptor;
@@ -80,25 +75,6 @@ public void setUp() {
8075
//
8176
// }
8277
//
83-
// @Test
84-
// public void shouldCreateAuthAPIClientWithCustomHttpOptions() {
85-
// HttpOptions options = new HttpOptions();
86-
// options.setConnectTimeout(5);
87-
// options.setReadTimeout(6);
88-
//
89-
// ArgumentCaptor<HttpOptions> captor = ArgumentCaptor.forClass(HttpOptions.class);
90-
// AuthenticationController.Builder spy = spy(AuthenticationController.newBuilder("domain", "clientId", "clientSecret")
91-
// .withHttpOptions(options));
92-
//
93-
// spy.build();
94-
// verify(spy).createAPIClient(eq("domain"), eq("clientId"), eq("clientSecret"), captor.capture());
95-
//
96-
// HttpOptions actual = captor.getValue();
97-
// assertThat(actual, is(notNullValue()));
98-
// assertThat(actual.getConnectTimeout(), is(5));
99-
// assertThat(actual.getReadTimeout(), is(6));
100-
// }
101-
10278
// @Test
10379
// public void shouldDisableTelemetry() {
10480
// AuthenticationController controller = builderSpy.build();

‎src/test/java/com/auth0/AuthorizeUrlTest.java‎

Lines changed: 70 additions & 66 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
package com.auth0;
22

3-
import com.auth0.client.HttpOptions;
43
import com.auth0.client.auth.AuthAPI;
54
import com.auth0.exception.Auth0Exception;
65
import com.auth0.json.auth.PushedAuthorizationResponse;
76
import com.auth0.net.Request;
7+
import com.auth0.net.Response;
88
import okhttp3.HttpUrl;
99
import org.junit.jupiter.api.BeforeEach;
1010
import org.junit.jupiter.api.Test;
@@ -244,67 +244,75 @@ public void shouldThrowWhenChangingTheNonceUsingCustomParameterSetter() {
244244
assertEquals("Please, use the dedicated methods for setting the 'nonce' and 'state' parameters.", e.getMessage());
245245
}
246246

247-
// @Test
248-
// public void shouldGetAuthorizeUrlFromPAR() throws Exception {
249-
// AuthAPIStub authAPIStub = new AuthAPIStub("https://domain.com", "clientId", "clientSecret");
250-
// Request requestMock = mock(Request.class);
251-
//
252-
// when(requestMock.execute().getBody()).thenReturn(new PushedAuthorizationResponse("urn:example:bwc4JK-ESC0w8acc191e-Y1LTC2", 90));
253-
//
254-
// authAPIStub.pushedAuthorizationResponseRequest = requestMock;
255-
// String url = new AuthorizeUrl(authAPIStub, request, response, "https://domain.com/callback", "code")
256-
// .fromPushedAuthorizationRequest();
257-
//
258-
// assertThat(url, is("https://domain.com/authorize?client_id=clientId&request_uri=urn%3Aexample%3Abwc4JK-ESC0w8acc191e-Y1LTC2"));
259-
// }
260-
261-
// @Test
262-
// public void fromPushedAuthorizationRequestThrowsWhenRequestUriIsNull() throws Exception {
263-
// AuthAPIStub authAPIStub = new AuthAPIStub("https://domain.com", "clientId", "clientSecret");
264-
// Request requestMock = mock(Request.class);
265-
// when(requestMock.execute().getBody()).thenReturn(new PushedAuthorizationResponse(null, 90));
266-
//
267-
// authAPIStub.pushedAuthorizationResponseRequest = requestMock;
268-
//
269-
// InvalidRequestException exception = assertThrows(InvalidRequestException.class, () -> {
270-
// new AuthorizeUrl(authAPIStub, request, response, "https://domain.com/callback", "code")
271-
// .fromPushedAuthorizationRequest();
272-
// });
273-
//
274-
// assertThat(exception.getMessage(), is("The PAR request returned a missing or empty request_uri value"));
275-
// }
276-
277-
// @Test
278-
// public void fromPushedAuthorizationRequestThrowsWhenRequestUriIsEmpty() throws Exception {
279-
// AuthAPIStub authAPIStub = new AuthAPIStub("https://domain.com", "clientId", "clientSecret");
280-
// Request requestMock = mock(Request.class);
281-
// when(requestMock.execute().getBody()).thenReturn(new PushedAuthorizationResponse("urn:example:bwc4JK-ESC0w8acc191e-Y1LTC2", null));
282-
//
283-
// authAPIStub.pushedAuthorizationResponseRequest = requestMock;
284-
//
285-
// InvalidRequestException exception = assertThrows(InvalidRequestException.class, () -> {
286-
// new AuthorizeUrl(authAPIStub, request, response, "https://domain.com/callback", "code")
287-
// .fromPushedAuthorizationRequest();
288-
// });
289-
//
290-
// assertThat(exception.getMessage(), is("The PAR request returned a missing expires_in value"));
291-
// }
292-
293-
// @Test
294-
// public void fromPushedAuthorizationRequestThrowsWhenExpiresInIsNull() throws Exception {
295-
// AuthAPIStub authAPIStub = new AuthAPIStub("https://domain.com", "clientId", "clientSecret");
296-
// Request requestMock = mock(Request.class);
297-
// when(requestMock.execute().getBody()).thenReturn(new PushedAuthorizationResponse(null, 90));
298-
//
299-
// authAPIStub.pushedAuthorizationResponseRequest = requestMock;
300-
//
301-
// InvalidRequestException exception = assertThrows(InvalidRequestException.class, () -> {
302-
// new AuthorizeUrl(authAPIStub, request, response, "https://domain.com/callback", "code")
303-
// .fromPushedAuthorizationRequest();
304-
// });
305-
//
306-
// assertThat(exception.getMessage(), is("The PAR request returned a missing or empty request_uri value"));
307-
// }
247+
@Test
248+
public void shouldGetAuthorizeUrlFromPAR() throws Exception {
249+
AuthAPIStub authAPIStub = new AuthAPIStub("https://domain.com", "clientId", "clientSecret");
250+
Request requestMock = mock(Request.class);
251+
252+
Response<PushedAuthorizationResponse> pushedAuthorizationResponseResponse = mock(Response.class);
253+
when(requestMock.execute()).thenReturn(pushedAuthorizationResponseResponse);
254+
when(requestMock.execute().getBody()).thenReturn(new PushedAuthorizationResponse("urn:example:bwc4JK-ESC0w8acc191e-Y1LTC2", 90));
255+
256+
authAPIStub.pushedAuthorizationResponseRequest = requestMock;
257+
String url = new AuthorizeUrl(authAPIStub, request, response, "https://domain.com/callback", "code")
258+
.fromPushedAuthorizationRequest();
259+
260+
assertThat(url, is("https://domain.com/authorize?client_id=clientId&request_uri=urn%3Aexample%3Abwc4JK-ESC0w8acc191e-Y1LTC2"));
261+
}
262+
263+
@Test
264+
public void fromPushedAuthorizationRequestThrowsWhenRequestUriIsNull() throws Exception {
265+
AuthAPIStub authAPIStub = new AuthAPIStub("https://domain.com", "clientId", "clientSecret");
266+
Request requestMock = mock(Request.class);
267+
Response<PushedAuthorizationResponse> pushedAuthorizationResponseResponse = mock(Response.class);
268+
when(requestMock.execute()).thenReturn(pushedAuthorizationResponseResponse);
269+
when(requestMock.execute().getBody()).thenReturn(new PushedAuthorizationResponse(null, 90));
270+
271+
authAPIStub.pushedAuthorizationResponseRequest = requestMock;
272+
273+
InvalidRequestException exception = assertThrows(InvalidRequestException.class, () -> {
274+
new AuthorizeUrl(authAPIStub, request, response, "https://domain.com/callback", "code")
275+
.fromPushedAuthorizationRequest();
276+
});
277+
278+
assertThat(exception.getMessage(), is("The PAR request returned a missing or empty request_uri value"));
279+
}
280+
281+
@Test
282+
public void fromPushedAuthorizationRequestThrowsWhenRequestUriIsEmpty() throws Exception {
283+
AuthAPIStub authAPIStub = new AuthAPIStub("https://domain.com", "clientId", "clientSecret");
284+
Request requestMock = mock(Request.class);
285+
Response<PushedAuthorizationResponse> pushedAuthorizationResponseResponse = mock(Response.class);
286+
when(requestMock.execute()).thenReturn(pushedAuthorizationResponseResponse);
287+
when(requestMock.execute().getBody()).thenReturn(new PushedAuthorizationResponse("urn:example:bwc4JK-ESC0w8acc191e-Y1LTC2", null));
288+
289+
authAPIStub.pushedAuthorizationResponseRequest = requestMock;
290+
291+
InvalidRequestException exception = assertThrows(InvalidRequestException.class, () -> {
292+
new AuthorizeUrl(authAPIStub, request, response, "https://domain.com/callback", "code")
293+
.fromPushedAuthorizationRequest();
294+
});
295+
296+
assertThat(exception.getMessage(), is("The PAR request returned a missing expires_in value"));
297+
}
298+
299+
@Test
300+
public void fromPushedAuthorizationRequestThrowsWhenExpiresInIsNull() throws Exception {
301+
AuthAPIStub authAPIStub = new AuthAPIStub("https://domain.com", "clientId", "clientSecret");
302+
Request requestMock = mock(Request.class);
303+
Response<PushedAuthorizationResponse> pushedAuthorizationResponseResponse = mock(Response.class);
304+
when(requestMock.execute()).thenReturn(pushedAuthorizationResponseResponse);
305+
when(requestMock.execute().getBody()).thenReturn(new PushedAuthorizationResponse(null, 90));
306+
307+
authAPIStub.pushedAuthorizationResponseRequest = requestMock;
308+
309+
InvalidRequestException exception = assertThrows(InvalidRequestException.class, () -> {
310+
new AuthorizeUrl(authAPIStub, request, response, "https://domain.com/callback", "code")
311+
.fromPushedAuthorizationRequest();
312+
});
313+
314+
assertThat(exception.getMessage(), is("The PAR request returned a missing or empty request_uri value"));
315+
}
308316

309317
@Test
310318
public void fromPushedAuthorizationRequestThrowsWhenRequestThrows() throws Exception {
@@ -329,10 +337,6 @@ static class AuthAPIStub extends AuthAPI {
329337

330338
Request<PushedAuthorizationResponse> pushedAuthorizationResponseRequest;
331339

332-
public AuthAPIStub(String domain, String clientId, String clientSecret, HttpOptions options) {
333-
super(domain, clientId, clientSecret, options);
334-
}
335-
336340
public AuthAPIStub(String domain, String clientId, String clientSecret) {
337341
super(domain, clientId, clientSecret);
338342
}

0 commit comments

Comments
 (0)