Commit b9feb34
committed
fix: prevent unnecessary user object updates causing infinite loops
This fixes an issue where getAccessTokenSilently would create a new user
object reference even when the user data hadn't changed, causing useEffect
hooks with user dependencies to re-run infinitely.
The reducer now uses deep equality comparison (lodash.isequal) instead of
reference equality when checking if the user object has changed. This prevents
unnecessary state updates and re-renders.
Changes:
- Added lodash.isequal dependency for deep equality comparison
- Updated GET_ACCESS_TOKEN_COMPLETE and HANDLE_REDIRECT_COMPLETE cases to use isEqual
- State is only updated when user content actually changes
Fixes #7871 parent f244784 commit b9feb34
3 files changed
+32
-3
lines changedSome generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
| 61 | + | |
61 | 62 | | |
62 | 63 | | |
63 | 64 | | |
| |||
95 | 96 | | |
96 | 97 | | |
97 | 98 | | |
98 | | - | |
| 99 | + | |
| 100 | + | |
99 | 101 | | |
100 | 102 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
3 | 4 | | |
4 | 5 | | |
5 | 6 | | |
| |||
35 | 36 | | |
36 | 37 | | |
37 | 38 | | |
38 | | - | |
| 39 | + | |
39 | 40 | | |
40 | 41 | | |
41 | 42 | | |
| |||
0 commit comments