Skip to content

Conversation

@gyaneshgouraw-okta
Copy link
Contributor

📝 Pull Request Description

Completes this PR - #930

🔄 Changes

  • Updated Auth0 SPA JS dependency from version 2.7.0 to 2.9.0.
  • Refactored the connectAccountWithRedirect API to use a dedicated scopes parameter instead of nesting it within authorization_params.
  • Updated documentation examples to reflect the new API structure for connecting third-party accounts.

🧪 Testing

  • Verified unit test

💥 Impact

  • Developers will have a cleaner API for specifying scopes when connecting third-party accounts.
  • The update improves consistency with other Auth0 SDK methods that use a top-level scopes parameter.
  • No breaking changes expected as this appears to be an API enhancement.

📋 Checklist

  • Code follows the project's coding standards
  • Tests have been added/updated
  • Documentation has been updated
  • All tests are passing

@gyaneshgouraw-okta gyaneshgouraw-okta requested a review from a team as a code owner November 18, 2025 05:53
@arpit-jn
Copy link
Contributor

@claude

@github-actions
Copy link

github-actions bot commented Nov 18, 2025

Claude finished @arpit-jn's task —— View job


Code Review

Overall Assessment

❌ This PR contains a critical API inconsistency that will cause runtime errors. The EXAMPLES.md file uses authorization_params (snake_case) while the TypeScript interface requires authorizationParams (camelCase). This must be fixed before merging.

Issues Found

  1. Critical: Property naming inconsistency in EXAMPLES.md (authorization_params vs authorizationParams)
  2. Documentation Gap: The removal of access_type: 'offline' parameter needs explanation or migration guidance

Positive Changes

  • Dependency upgrade to auth0-spa-js v2.9.0 is clean
  • Top-level scopes parameter improves API consistency
  • TypeScript types are correctly imported and used

Job RunBranch

Copy link
Contributor

@arpit-jn arpit-jn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gyaneshgouraw-okta gyaneshgouraw-okta merged commit 284b24f into main Nov 18, 2025
12 checks passed
@gyaneshgouraw-okta gyaneshgouraw-okta deleted the feature/connected-scopes branch November 18, 2025 10:39
gyaneshgouraw-okta added a commit that referenced this pull request Nov 18, 2025
**Added**
- Refactor connectAccountWithRedirect to Use Top-Level Scopes and
Upgrade Auth0 SPA JS to v2.9.0
[\#933](#933)
([gyaneshgouraw-okta](https://github.com/gyaneshgouraw-okta))
- docs: Add Ask DeepWiki badge to README
[\#922](#922)
([arpit-jn](https://github.com/arpit-jn))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants