Clean up transaction data regardless of success/failure

Author: sam-muncke

src/auth0_server_python/auth_server/server_client.py

@@ -1428,16 +1428,13 @@ async def complete_connect_account(
             redirect_uri=transaction_data.redirect_uri,
             code_verifier=transaction_data.code_verifier
         )
-
-        response = await self._my_account_client.complete_connect_account(
-            access_token=access_token,
-            request=request
-        )
-
-        if transaction_data.app_state is not None:
-            response.app_state = transaction_data.app_state
-
-        # Clean up transaction data after successful account connection
-        await self._transaction_store.delete(transaction_identifier, options=store_options)
-
-        return response
+        try:
+            response = await self._my_account_client.complete_connect_account(
+                access_token=access_token, request=request)
+            if transaction_data.app_state is not None:
+                response.app_state = transaction_data.app_state
+        finally:
+            # Clean up transaction data
+            await self._transaction_store.delete(transaction_identifier, options=store_options)
+
+        return response